Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/323#discussion_r75396631
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -93,10 +102,24 @@ GradleBuilder.prototype.prepBuildFiles = function() {
// Update dependencies within build.gradle.
var buildGradle = fs.readFileSync(path.join(this.root,
'build.gradle'), 'utf8');
var depsList = '';
+ var root = this.root;
+ var insertExclude = function(p) {
+ var gradlePath = path.join(root, p, 'build.gradle');
+ var projectGradleFile = fs.readFileSync(gradlePath, 'utf-8');
+ if(projectGradleFile.indexOf('CordovaLib') != -1) {
--- End diff --
It should be safe to add the exclude, since CordovaLib itself will be
included in the project. We require this exclusion because if you make plugins
modules, you have to include the CordovaLib file somehow for Android Studio to
work properly. In the near future, we should just use the AAR and not have to
deal with this slower solution. However, it's good to have this just in case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
