Github user tony-- commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/323#discussion_r75392931
  
    --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
    @@ -93,10 +102,24 @@ GradleBuilder.prototype.prepBuildFiles = function() {
         // Update dependencies within build.gradle.
         var buildGradle = fs.readFileSync(path.join(this.root, 
'build.gradle'), 'utf8');
         var depsList = '';
    +    var root = this.root;
    +    var insertExclude = function(p) {
    +          var gradlePath = path.join(root, p, 'build.gradle');
    +          var projectGradleFile = fs.readFileSync(gradlePath, 'utf-8');
    +          if(projectGradleFile.indexOf('CordovaLib') != -1) {
    --- End diff --
    
    What if there is a reference to MyCordovaLib or CordovaLib appears in a 
comment?
    Will it be safe to add the exclude if there is not really a reference to 
CordovaLib?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to