Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63258721
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType, buildarch, o
args.push('/p:' + key + '=' + otherConfigProperties[key]);
});
}
+ var that = this;
- return spawn(path.join(this.path, 'msbuild'), [projFile].concat(args),
{ stdio: 'inherit' });
+ // Check if SDK required to build the respective platform is present.
If not present, return with corresponding error, else call msbuild.
+ if (projFile.indexOf('CordovaApp.Phone.jsproj') > -1) {
--- End diff --
Anyway, this is just a matter of taste, and i'm fine with your approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
