Hi - I'm looking for input on this issue: For the plugin/platform --save 
feature, there's currently an inconsistency between how we store the 
information in config.xml for platforms vs plugins.



For platforms, we have a 'version' attribute where we store either the source 
location or the version: if the platform was added by specifying a specific 
location (git repository, local folder, package file etc), we store that in the 
'version' attribute. Otherwise we store the actual version.



For plugins, these two values are stored separately - source location in the 
'src' attribute and version in the 'version' attribute. Note however that when 
we restore a plugin, we ignore the 'version' attribute if there is a 'src' 
attribute.



I'd like to make these consistent. My first thought was to support 'version' 
and 'src' for platforms like we currently do for plugins. But since we always 
ignore the version if we have a src, I'm not sure we actually gain anything by 
doing that. Storing them in different attributes is perhaps clearer, but 
storing both implies we make use of both, which we don't. Also, the code ends 
up being simpler overall if we just store whichever we care about in the 
version attribute.



Any thoughts either way?



Thanks!



Tim


Reply via email to