Just a bit confused here
For committers code reviews are done in reviews.apache.org
For contributors code reviews are done in github.com
Why?
Guessing here:
Committers don't use pull request system of github.com, they use git
on git-wip-us.apache.org server and for some reason committers are not
allow to do code reviews suing github pull requests and site?
Maybe I got frustrated with reviews.apache.org because I didn't get the
rbtools to work on my mac, and since I'm not a committer maybe I should
stick with github pull requests.
--Carlos
On Tue, Jul 9, 2013 at 9:45 AM, Andrew Grieve <agri...@chromium.org> wrote:
> Yeah, I'd say our current state is that we're "testing the waters" with it.
> Not yet ready to tell 3rd party devs to use it instead of github.
>
> It has been added to http://wiki.apache.org/cordova/CommitterWorkflow,
>
> For cordova-site, I realize that I haven't yet added a .reviewboardrc to
> it, so uploading a review wouldn't be as smooth as for the other repos.
> Will get on this.
>
>
>
>
> On Tue, Jul 9, 2013 at 9:38 AM, Michal Mocny <mmo...@chromium.org> wrote:
>
> > reviews.apache.org is just a place to submit patches for review, manage
> > comments on lines of code etc.
> >
> > Some of us have started using it to organize reviews of patches. Its not
> > the most beautiful interface, but it serves its purpose.
> >
> > I just tried it and submitting a new review I see many more than three
> > items (heck, cordova itself has like 20 repositories now).
> >
> > We probably should mention it in the workflow, but its not a mandatory
> > item, just a tool for those who are interested.
> >
> > -Michal
> >
> >
> > On Tue, Jul 9, 2013 at 9:31 AM, Carlos Santana <csantan...@gmail.com>
> > wrote:
> >
> > > Thanks Andrew
> > >
> > > What's the deal with https://reviews.apache.org ? I found it empty
> > (i.e. 3
> > > items)
> > >
> > > Is the Apache Cordova project migrating to it soon?, people don't know
> > > about it?
> > >
> > > If the Cordova Project wants to make it part fo the dev workflow it
> might
> > > help to document it on the Wiki
> > > http://wiki.apache.org/cordova/ContributorWorkflow
> > >
> > > I try using it and I failed, if someone can write a short cheat for it
> > that
> > > will be awesome.
> > >
> > > -Carlos
> > >
> > >
> > > On Mon, Jul 8, 2013 at 9:36 PM, Andrew Grieve <agri...@chromium.org>
> > > wrote:
> > >
> > > > I got the site added to review.apache.org, so in the future we can
> use
> > > > that
> > > > for reviewing changes / new blog posts.
> > > >
> > > > I'll apply your patch tomorrow :).
> > > >
> > > >
> > > > On Mon, Jul 8, 2013 at 5:33 PM, Carlos Santana <csantan...@gmail.com
> >
> > > > wrote:
> > > >
> > > > > I'm good for staging and review new features on GitHub Pages before
> > > > pushing
> > > > > live content to svn/infra
> > > > >
> > > > >
> > > > > On Mon, Jul 8, 2013 at 5:16 PM, Brian LeRoux <b...@brian.io> wrote:
> > > > >
> > > > > > > Did I forgot to say I don't love SVN.
> > > > > >
> > > > > > Ya.
> > > > > >
> > > > > >
> > > > > > > Can we host this on gtihub pages and maintain the website on
> > > Github,
> > > > > and
> > > > > > > let github run jekyll on the source code?
> > > > > >
> > > > > > Unfortunately no. We could use Github for 'staging' I guess.
> > > > > >
> > > > > >
> > > > > > > Downloads and Docs files will still be available from
> > > > > > > http://cordova.apache.org/downloads and
> > > > > http://cordova.apache.org/docsbut
> > > > > > > the website and blog will live in Github.
> > > > > >
> > > > > > Again, no. The website needs to be on Apache infra. =/
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Carlos Santana
> > > > > <csantan...@gmail.com>
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Carlos Santana
> > > <csantan...@gmail.com>
> > >
> >
>
--
Carlos Santana
<csantan...@gmail.com>
