Thanks for the feedback! I've revised to take it into account. I'll try to
reply inline to indicate how.

On Mon, Jan 7, 2019 at 1:02 AM Bertrand Delacretaz <bdelacre...@apache.org>
wrote:

> On Fri, Jan 4, 2019 at 10:35 PM Kenneth Knowles <k...@apache.org> wrote:
> > On Wed, Oct 31, 2018 at 8:51 AM Bertrand Delacretaz <
> bdelacre...@apache.org>
> > wrote:
> > >... Feel free to draft your blog post and we can then review and
> publish!
> > I've drafted it....
>
> Thank you, I reviewed [1] and it looks great to me!
>
> I have just 3 minor comments:
>
> -Add a link to the committer guidelines that you mention
>

The first sentence of the paragraph on that was a link. Something about my
source is making most links not render. I got this one working, but many
others are not. I'll figure that out...


> -IIUC when you say "Every ~month" it means "about every month" - that
> was not obvious to me initially
>

Changed to "about every month"


> -for RTC and CTR you might link to
> https://www.apache.org/foundation/glossary.html


Done (but link is not yet working per above)


>
> -Bertrand




On Mon, Jan 7, 2019 at 5:11 PM Craig Russell <apache....@gmail.com> wrote:

> I realize that this message might be hard to read since copy/paste
> formatting is gone. So here goes my attempt to clarify...
>
> On Jan 7, 2019, at 8:28 AM, Craig Russell <apache....@gmail.com> wrote:
>
> Hi Kenn,
>
> Thanks for contributing this. I think it's a nice introduction to Beam's
> community building efforts.
>
> Here are a couple of comments:
>
> > We want our contributor-base (hence committer-base) to be more spread
> across companies and backgrounds, for the usual Apache reasons.
>
> I'd elaborate instead of saying "for the usual Apache reasons". Which
> reasons are important to Beam?
>

Done.


> > (we have committers from community development, tech writing, training,
> etc).
>
> I'd make this a sentence of its own.
>

Agree. Done.



> > you shouldn't be proposing a committer for other reasons,
>
> I don't understand "for other reasons".
>
> > Every ~month, we call for new discussions and revisit ~all prior
> discussions.
>
> I find the "~" to be distracting. Words please.
>

Done.

> For a potential committer, we did this:
>
> It's not clear to me when a person becomes a potential committer. Is it in
> the "repeat contributor" phase?
>
> > For an early contributor,
>
> Perhaps move this paragraph above the "For a potential committer"
> paragraph?
>

Done. I think re-ordering and slight rephrase helped.

> ~3~4 obvious committer candidates


> As above, remove "~".
>

Done. "a few"

> If we have no feedback about which guidelines were a concern, that is a
> red flag that we are being driven by bias.
>
> I don't understand this. Lack of concern might be considered a "good
> thing" not a red flag.
>

Rephrased: "Formulating this feedback is important for helping contributors
to learn, but it also serves as a check against bias and politics. If we
found ourselves unable to specify such feedback, that is a sign that we are
deciding for a reason other than those we have declared and agreed upon."

> as RMS says
>
> Who/what <https://teams.googleplex.com/u/what> is RMS?
>

Rephrased and spelled out his name.

I'll keep trying to figure out what is going on with the links, and if you
know the answer please share it!

Kenn


>
> Regards,
>
> Craig
> >> On Jan 4, 2019, at 1:49 PM, Kenneth Knowles <k...@apache.org <mailto:
> k...@apache.org>> wrote:
> >>
> >> Here it is:
> >>
> https://blogs.apache.org/roller-ui/authoring/preview/comdev/?previewEntry=an-approach-to-community-building
> <
> https://blogs.apache.org/roller-ui/authoring/preview/comdev/?previewEntry=an-approach-to-community-building
> >
> >>
> >> Kenn
> >>
> >> On Fri, Jan 4, 2019 at 1:44 PM Griselda Cuevas <g...@google.com.invalid
> >
> >> wrote:
> >>
> >>> Where could we find it?
> >>>
> >>>
> >>>
> >>>
> >>> On Fri, 4 Jan 2019 at 13:35, Kenneth Knowles <k...@apache.org> wrote:
> >>>
> >>>> On Wed, Oct 31, 2018 at 8:51 AM Bertrand Delacretaz <
> >>>> bdelacre...@apache.org>
> >>>> wrote:
> >>>>
> >>>>> Feel free to draft your blog post and we can then review and publish!
> >>>>>
> >>>>
> >>>> I've drafted it. It is pretty long but still feels terse to me.
> Feedback
> >>>> very welcome on that point. I will try to find time to give it another
> >>>> pass, unless someone tells me that it is fine as-is.
> >>>>
> >>>> Kenn
> >>>>
> >>>>
> >>>> -Bertrand
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
> >>>>> For additional commands, e-mail: dev-h...@community.apache.org
> >>>>>
> >>>>>
> >>>>
> >>>
> >
> > Craig L Russell
> > Secretary, Apache Software Foundation
> > c...@apache.org <mailto:c...@apache.org> http://db.apache.org/jdo <
> http://db.apache.org/jdo>
>
> Craig L Russell
> Secretary, Apache Software Foundation
> c...@apache.org <mailto:c...@apache.org> http://db.apache.org/jdo <
> http://db.apache.org/jdo>
>

Reply via email to