On Sun, Apr 26, 2026, 16:48 Piotr P. Karwasz <[email protected]> wrote:
> Hi Elliotte, > > On 24.04.2026 13:13, Elliotte Rusty Harold wrote: > > My initial impression of the code itself is that it's overly complex, > > and likely falls prey to some common Java antipatterns. You don't need > > multiple packages or internal and spi packages. One package with many > > fewer public classes and methods is fully sufficient. > > > Separating `spi` and an `internal` package (which is not exported by > JPMS) is my personal preference to show users, which classes they can > use, which ones classify them as implementors (and they might need to > make a new release at each minor version bump) and which classes are > forbidden. > > However, I could put everything in a single package with only one public > class. > I like that best. This allows proper visibility using Java 8 and doesn't require JPMS to make a public class hidden. Gary > > Piotr > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
