I saw today that my PR was merged to master. I hope this is the right place to do it.
I want to thank Gary Gregory and Claude Warren for their time reviewing my PR and for their support leading me into the right direction in my first PR. This contribution has a lot of value to me and I learned a lot with this experience. I hope we can continue to collaborate in the future. Thank you! Have a great day, Ricardo Mendes Ricardo Mendes IMPORTANT: The contents of this email and any attachments are confidential. They are intended for the named recipient(s) only. If you have received this email by mistake, please notify the sender immediately and do not disclose the contents to anyone or make copies thereof. On Wed, 1 May 2024 at 09:24, Ricardo Mendes <ricardominamen...@gmail.com> wrote: > > Thank you, > > I have submitted a draft PR as instructed. > > > On Wed, 1 May 2024 at 07:10, Claude Warren <cla...@xenei.com> wrote: >> >> Ricardo, >> >> Thank you for your effort and contribution. I find it difficult to >> evaluate your work without a pull request (a draft one will do) to show >> what changes you have made. It just makes reviewing much easier. Can you >> open a draft pull request please? >> >> Claude >> >> On Wed, May 1, 2024 at 3:54 AM Ricardo Mendes <ricardominamen...@gmail.com> >> wrote: >> >> > Good evening, >> > >> > I have been working on a new small feature which aims to validate if a >> > value is present in a configuration through a first match validation. >> > >> > This is useful when looking for specific values in multiple configurations >> > and often can be leveraged to return the right Configuration if a value is >> > present. >> > >> > It can also be used to validate the integrity of a Configuration. >> > >> > It is natively present in *java.util.Properties* (see JavaDoc >> > < >> > https://docs.oracle.com/javase/8/docs/api/java/util/Hashtable.html#containsValue-java.lang.Object- >> > > >> > ). >> > >> > I would like to ask if you find this worthy of being added to >> > *commons.configuration2* and I would like to ask if it is ok if I submit a >> > PR with this implementation? >> > >> > *My fork: * >> > >> > https://github.com/rikkarth/commons-configuration/tree/feat/configuration-contains-value >> > >> > Worth noting that this is my first implementation and I haven't written any >> > JavaDoc or cleaned up (too much at least). >> > >> > I've made some tests which are passing (not on GitHub apparently). >> > >> > I would appreciate any feedback in regards to this implementation. >> > >> > Thank you for your time and consideration. >> > >> > Best Regards >> > Ricardo Mendes >> > >> >> >> -- >> LinkedIn: http://www.linkedin.com/in/claudewarren --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
