I think someone will have to confirm if a) we are following that standard or b) the code used short only for some reason like a previous version or a simpler standard etc.
I suspect it might be just a matter of changing that, but the change must come after the confirmation and with a unit test. I have some spare time now but I am working on other open source projects. Will have a look later if no one has fixed it yet. Bruno On Wed, 3 Jan 2024, 00:00 Glavo, <zjx001...@gmail.com> wrote: > Also, I remembered that I encountered a problem when developing another > PR[1]: > > When I created the test, I noticed the type of EXIF_TAG_EXIF_IMAGE_WIDTH > > and EXIF_TAG_EXIF_IMAGE_LENGTH is TagInfoShort. > > > > However, in the standard document > > <https://www.cipa.jp/std/documents/e/DC-X008-Translation-2019-E.pdf>, > the > > field type is SHORT or LONG. > > > > Unfortunately, the test image I found uses the LONG type field to record > > ExifImageWidth and ExifImageLength, so I found this problem. > > > > Fixing it will make incompatible changes to the API, so it should be fixed > as soon as possible. > I won't be able to get back to this work anytime soon, so can anyone else > fix it for me? > > Glavo > > [1]: > https://github.com/apache/commons-imaging/pull/269#issuecomment-1381983655 > > On Wed, Jan 3, 2024 at 5:44 AM Bruno Kinoshita <brunodepau...@gmail.com> > wrote: > > > I don't mind staying with alpha until we are closer to having most 1.0 > > blocking issues sorted out (we have one for java.desktop and java+9 and > > android I think, not sure if in 1.0). > > > > Cheers > > > > On Tue, 2 Jan 2024, 21:32 Glavo, <zjx001...@gmail.com> wrote: > > > > > > I plan on releasing a milestone 1.0-M1 version this month, so not > quite > > > 1.0 but a signal that we are close. > > > > > > I think it's a bit premature. I think commons-imaging should not depend > > on > > > java.desktop, > > > otherwise it will be unavailable on some platforms (such as Android or > > > other platforms that do not include java.desktop). > > > I hope you'll consider my suggestions here[1] before taking it out of > the > > > alpha phase. > > > > > > Glavo > > > > > > [1]: > > > > > > https://github.com/apache/commons-imaging/pull/254#issuecomment-1352708022 > > > > > > On Tue, Jan 2, 2024 at 11:53 PM Gary Gregory <garydgreg...@gmail.com> > > > wrote: > > > > > > > I plan on releasing a milestone 1.0-M1 version this month, so not > quite > > > 1.0 > > > > but a signal that we are close. > > > > > > > > Gary > > > > > > > > > > > > On Tue, Jan 2, 2024, 10:46 AM William Borg Barthet < > > > > william.borgbart...@bloomreach.com> wrote: > > > > > > > > > Hi Bruno, > > > > > > > > > > Thanks for your reply. I did check out and try out the PR. It seems > > to > > > > work > > > > > fine. > > > > > > > > > > Do you have any idea when the project will be released? I'd rather > > not > > > > have > > > > > my project depend on a snapshot version. > > > > > > > > > > Thanks and regards > > > > > > > > > > William > > > > > > > > > > On 2023/12/13 15:49:31 Bruno Kinoshita wrote: > > > > > > Hi, we made some progress on reading webp, but it's not complete, > > and > > > > the > > > > > > writing features are still missing. I think the partial webp > > reading > > > > > > feature has not been released yet, but it was already merged in > > > master. > > > > > > > > > > > > https://github.com/apache/commons-imaging/pull/254 > > > > > > > > > > > > Feel free to test the latest version and provide any feedback, > and > > > > should > > > > > > you have time to work on some improvements in the code, feel free > > to > > > > > submit > > > > > > pull requests too. I am busy at $work right now (workflows and > > > climate, > > > > > > unfortunately not much imaging nor Java as it's mainly > > > Python/Fortran) > > > > so > > > > > > not likely to have much time to work on it. > > > > > > > > > > > > Bruno > > > > > > > > > > > > On Wed, 13 Dec 2023 at 16:30, William Borg Barthet < > > > > > > william.borgbart...@bloomreach.com> wrote: > > > > > > > > > > > > > Hi there, > > > > > > > > > > > > > > I see on your roadmap that WEBP support is planned. Has this > > > already > > > > > been > > > > > > > developed in an unreleased version? When will there be another > > > > release > > > > > of > > > > > > > the apache commons imaging project? > > > > > > > > > > > > > > https://commons.apache.org/proper/commons-imaging/roadmap.html > > > > > > > > > > > > > > Thanks in advance, > > > > > > > > > > > > > > William > > > > > > > > > > > > > > > > > > > > > > > > > > > >
