On Sun, 8 Oct 2023 at 18:52, Gary Gregory <garydgreg...@gmail.com> wrote: > > The default goal is always used by GitHub builds
Are you sure about that? GH does not automatically know how to call Maven. We have to configure the calls in the workflows. Not all workflows rely on the default goal, though most do. > and it is nice to use as a dev before you push. > This lets us avoid putting some custom mvn call in the > GH build definition. We can also document to users that calling 'mvn' is a > all you need to do to validate a PR or push. But only if the defaultGoal is suitably configured. AFAICT that is not the case for all components at present. > Gary > > On Sun, Oct 8, 2023, 1:25 PM Phil Steitz <phil.ste...@gmail.com> wrote: > > > What exactly is the point of the default goal? I mean when is it expected > > to be used? Automations? Pipes of some kind? It’s not always executed, > > right? So if I say “clean” was the default, “mvn test” would not mean “mvn > > clean test”, right? > > > > Phil > > > > > On Oct 8, 2023, at 7:11 AM, sebb <seb...@gmail.com> wrote: > > > > > > There are currently lots of variations of the defaultGoal in different > > > components. > > > > > > It may be sensible to establish a standard setting which components > > > should adopt (unless there is a good reason to do otherwise). > > > > > > If so, what should that be, and where does it get documented? > > > > > > Personally, I don't think install should ever be a default goal as it > > > changes the environment outside the component. > > > > > > Main goals seen: > > > clean > > > install > > > package > > > site > > > test > > > verify > > > > > > Other goals seen: > > > apache-rat:check > > > checkstyle:check > > > clirr:check > > > findbugs:check > > > japicmp:cmp > > > javadoc:javadoc > > > pmd:check > > > pmd:cpd-check > > > spotbugs:check > > > > > > Sebb > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
