(verify includes test and package)
Looks like there is some consensus for:
clean verify
-- plus --
apache-rat:check
checkstyle:check
japicmp:cmp
javadoc:javadoc
pmd:check
spotbugs:check
I think these should be optional:
pmd:cpd-check
revapi:check
On Sun, 8 Oct 2023 at 17:04, sebb <seb...@gmail.com> wrote:
>
> On Sun, 8 Oct 2023 at 15:38, Gilles Sadowski <gillese...@gmail.com> wrote:
> >
> > Le dim. 8 oct. 2023 à 16:11, sebb <seb...@gmail.com> a écrit :
> > >
> > > There are currently lots of variations of the defaultGoal in different
> > > components.
> > >
> > > It may be sensible to establish a standard setting which components
> > > should adopt (unless there is a good reason to do otherwise).
> >
> > +1
> >
> > >
> > > If so, what should that be,
> >
> > Anything and everything that would lead to a -1 by the reviewer
> > (if just to avoid spending cycles on something that could have
> > been detected automatically).
> >
> > > and where does it get documented?
> >
> > Can it be defined in "commons-parent" POM file?
>
> Good idea.
>
> CP could define it as a property, and POMs can use:
> <defaultGoal>${commons.defaultGoal}</defaultGoal>
>
> > >
> > > Personally, I don't think install should ever be a default goal as it
> > > changes the environment outside the component.
> >
> > +1
> >
> > >
> > > Main goals seen:
> > > clean
> > > install
> > > package
> > > site
> > > test
> > > verify
> >
> > $ mvn clean test verify
> > Isn't "test" included in "verify"?
> >
> > >
> > > Other goals seen:
> > > apache-rat:check
> > > checkstyle:check
> > > clirr:check
> > > findbugs:check
> > > japicmp:cmp
> > > javadoc:javadoc
> > > pmd:check
> > > pmd:cpd-check
> > > spotbugs:check
> >
> > +1 (all of the above, plus "revapi:check")
> >
> > Regards,
> > Gilles
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
