On Sun, 18 Dec 2022, 23:06 Gilles Sadowski, <gillese...@gmail.com> wrote:
> Le dim. 18 déc. 2022 à 23:10, Alex Herbert <alex.d.herb...@gmail.com> a
> écrit :
> >
> > I think the name for the distribution archive is collected in:
> >
> > dist-archive/src/assembly/[bin|src].xml
> >
> > These use ${project.artifactId}-${project.version} by specifying the
> > <baseDirectory> tag.
> >
> > So renaming the artifactId for the dist-archive in the pom.xml from
> > commons-math to commons-math4 fixes this.
>
> Thus the "mistake" is in the definition of <artifactId> in the
> "dist-archive" module: By the current convention, it must be
> "commons-math4". [Similarly to the <artifactId> of module
> "commons-math-core" being "commons-math4-core".]
>
> Now I wonder: Is this distinction (with or without the "4") really
> necessary in what the elements are used for?
> E.g. for the file names referred to in the previous message:
> commons-math-4.0-beta1-bin.tar.gz
> vs
> commons-math4-4.0-beta1-bin.tar.gz
> why is the latter better than the former?
> IOW, the "4" is redundant since it is present in the "version"
> string. So why keep track, in the POM files, of distinct strings
> "commons-math" and "commons-math4" if wherever they are
> used, the "version" string is also used?
>
> Hence, could we adopt a new, less error-prone, convention that
> will be simpler: <artifactId> is always composed of the string
> "commons", a hyphen, and the name of the component,
> irrespective of version?
>
I don't know the history here but looking at commons Lang the download for
the 2.x line does not have lang2 in the name but for the 3.x line it does
have lang3.
https://commons.apache.org/proper/commons-lang/download_lang.cgi
I thought the artifact id was used in commons to match the package name. So
you can import math3 and math4 artifacts. So it is important for jar
artifacts.
But for the distribution module having the math4 is redundant, but also
harmless to keep it included.
Alex
> Gilles
>
> > Verified using:
> >
> > > mvn assembly:single
> >
> > from within the dist-archive module.
> >
> > Note that if the <baseDirectory> tag is removed from the assembly
> > descriptors then the final output archive name is
> > ${project.build.finalName} [1]. This results in the same output using
> > ${project.artifactId}-${project.version} to create:
> >
> > commons-math4-4.0-SNAPSHOT-src.tar.gz
> > commons-math4-4.0-SNAPSHOT-src.zip
> > commons-math4-4.0-SNAPSHOT-bin.tar.gz
> > commons-math4-4.0-SNAPSHOT-bin.zip
> >
> > Alex
> >
> > [1] https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html
> >
> > On Sun, 18 Dec 2022 at 19:55, Gilles Sadowski <gillese...@gmail.com>
> wrote:
> > >
> > > Hi.
> > >
> > > > [...]
> > > >
> > > > Distribution files and release notes:
> > > > https://dist.apache.org/repos/dist/dev/commons/math/
> > > >
> > > > To verify the integrity of the distribution files, you can
> > > >
> > > > 1. download them with the command
> > > > $ wget -nH --cut-dirs=8 \
> > > >
> https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/binaries/commons-math-4.0-beta1-bin.tar.gz
> \
> > > >
> https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/binaries/commons-math-4.0-beta1-bin.zip
> \
> > > >
> https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/source/commons-math-4.0-beta1-src.tar.gz
> \
> > > >
> https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/source/commons-math-4.0-beta1-src.zip
> > > >
> > >
> > > There is a glitch here: Prefix in those file names should have been
> > > commons-math4
> > > but it is
> > > commons-math
> > >
> > > The names can be fixed while copying to the "release" directory of
> > > the "dist" server, without side-effects (I think).
> > > But I don't know what (the "commons-release-plugin" ?) picked
> > > which variable, and where, rather than the element (in the main
> > > "pom.xml"):
> > > <commons.release.name>commons-math4-${project.version}</
> commons.release.name>
> > > that seems intended (?) to match the release file names.
> > > [Of course, this issue wouldn't show up in the 1.x release of a
> > > component.]
> > >
> > > Gilles
> > >
> > > > [...]
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
