Le sam. 17 déc. 2022 à 20:27, Alex Herbert <alex.d.herb...@gmail.com> a écrit :
>
> Verified the checksums on the source and binary archives.
>
> Verified the binary jar files have the correct module entries in the
> MANIFEST.MF.
>
> Built from the git tag using: 'mvn'
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/apache-maven-3.6.3
> Java version: 1.8.0_301, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_301.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"
>
> Built from the tar source using: mvn site site:stage
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/apache-maven-3.6.3
> Java version: 17, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "12.6.1", arch: "x86_64", family: "mac"
>
> Notes on the site:
Personally, I don't understand why Commons continues to
link web site maintenance and a release vote (released items
comprise Javadoc generated from the corresponding source).
>
> The developer guide on the site could do with an update to reflect
> github PRs (see the numbers, rng guide etc). Adding a .gitattributes
> to the repo would make redundant the developer notes on setting up git
> config for line endings.
OK.
Done in commit 84d2c948bbb7f1d8e8db534ecb206d1358466b4a
>
> There is no release history page. However it does duplicate
> information in the changes report. So perhaps other sites that have a
> release history page should drop it. One to discuss.
+1 to drop redundant info.
>
> The changes report has a big TBD at the top of the page.
Indeed. Forgot to remove that; but I don't know that it makes
any difference, as it would reappear at the next update of the
site (based on the version in "master" of "changes.xml").
If we consider the "RELEASE-NOTES.txt" text file to be the
"authoritative" summary of the changes in that release, the
"changes" HTML report should not require adding yet another
step (to clean up the file in the "release" branch) to the release
process.
>
> The jira report is empty. I recently fixed this for BCEL which had
> some very old tickets that did not have a Priority label in the
> expected Major, Minor, etc. but used 1, 2, 3, etc. These were legacy
> tickets ported from a Bugzilla system. Tracking them down required
> locally building the maven-changes-plugin and printing out all the
> tickets where the priority was returned as null, causing a NPE.
Isn't that a bug in "maven-changes-plugin"?
Could we fix this through JIRA?
>
> In the userguide overview there is no mention of the legacy module.
Yes. I postponed the resolution of
https://issues.apache.org/jira/browse/MATH-1604
to "4.X".
> Some sort of statement that captures the intent to provide backward
> compatibility for functionality in CM3 in the legacy module
I indicated in the release notes what the intent really is. ;-)
> and that
> new code will be added into new modules would be useful.
>
> The overview section 0.3 has the packages: complex; distribution;
> fraction; geometry. These do not exist in the code. However the links
> are useful as when followed they point to the new Commons projects
> containing the updated code.
Sections intentionally left in (for the reason which you mention).
> Perhaps the links for packages removed in
> 4.0 should be placed below under a section for migrated code.
I think that it is clear(er) as it is (as advertisement for the new
components). [But I won't mind another layout.]
>
> The latest API docs link is broken as the structure is now modular.
> This could be fixed using an aggregate docs module (see numbers, rng)
> that builds an aggregate javadoc across the entire set of modules and
> uses this in the site link for the javadoc.
+1
> No real issues here, just things to tidy up.
>
> +1 Release it
>
> Alex
>
> On Thu, 15 Dec 2022 at 19:10, Gilles Sadowski <gillese...@gmail.com> wrote:
> >
> > Hello.
> >
> > This is a VOTE for releasing Apache Commons Math v4.0-beta1 (from RC1).
> > [Thanks for the help to get there!]
> >
> > Tag name:
> > commons-math-4.0-beta1-RC1
> >
> > Command for checking out the project corresponding to this tag:
> > $ git clone https://gitbox.apache.org/repos/asf/commons-math.git
> > --branch commons-math-4.0-beta1-RC1
> >
> > From within the "commons-math" directory created by the above command, you
> > can
> > 1. check the tag signature with the command
> > $ git tag -v commons-math-4.0-beta1-RC1
> >
> > 2. build the project[1] with the command
> > $ mvn
> >
> > Tag URL:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-math.git;a=commit;h=12ad3420a77611557603d1c7893d588610b2463a
> >
> > Commit ID the tag points at:
> > 12ad3420a77611557603d1c7893d588610b2463a
> >
> > Site:
> > http://home.apache.org/~erans/commons-math-4.0-beta1-site/
> >
> > Distribution files and release notes:
> > https://dist.apache.org/repos/dist/dev/commons/math/
> >
> > To verify the integrity of the distribution files, you can
> >
> > 1. download them with the command
> > $ wget -nH --cut-dirs=8 \
> >
> > https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/binaries/commons-math-4.0-beta1-bin.tar.gz
> > \
> >
> > https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/binaries/commons-math-4.0-beta1-bin.zip
> > \
> >
> > https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/source/commons-math-4.0-beta1-src.tar.gz
> > \
> >
> > https://dist.apache.org/repos/dist/dev/commons/math/4.0-beta1-RC1/source/commons-math-4.0-beta1-src.zip
> >
> > 2. copy/paste the following excerpt (hash of the distribution files)
> > into a text file (say "sha512.txt"):
> > ---CUT---
> > # <hash> <file>
> > 4a535ba815bd74eab4890d2a99ecfbe719927521b547119d68b03d87e6984f6ca41b9ee66cd4bd37bfc77762f0146227b7bd4a2157500aabfa20ce674fc9f8ab
> > commons-math-4.0-beta1-bin.tar.gz
> > 3951e7d287032cb2beb966a5259c5ce6c64830fa9570a4659e4e36b74eecfd941ccc8c729dff1b9db1d695301e6a83e2ec35e49c54520c35d93146bfcafcf024
> > commons-math-4.0-beta1-bin.zip
> > 668f552c444c7328bfb4e73bfba031e00d56212fc38a5d587ac9809ae63547b1caec7edb46a808dd62054601aaca696c3afa9fc4b6e5daa38d8c0db0f31a2ccd
> > commons-math-4.0-beta1-src.tar.gz
> > 829be0c697a225087442b4b2b5ffdb8cbc337ab4d170b2a815f231528795278b68612bf1cdd6ace2e68880556789d960c07f19c42c6329165ebb2d79426337f8
> > commons-math-4.0-beta1-src.zip
> > ---CUT---
> >
> > 3. run the command
> > $ sha512sum -c sha512.txt
> >
> > KEYS file to check signatures:
> > http://www.apache.org/dist/commons/KEYS
> >
> > Maven artefacts:
> > https://repository.apache.org/content/repositories/orgapachecommons-1613/
> >
> > [ ] +1 Release it.
> > [ ] +0 Go ahead; I don't care.
> > [ ] -0 There are a few minor glitches: ...
> > [ ] -1 No, do not release it because ...
> >
> > This vote will be open for at least 72 hours.
> >
> > Best regards,
> > Gilles
> >
> > [1] Tested with
> > $ mvn --version
> > Apache Maven 3.6.3
> > Maven home: /usr/share/maven
> > Java version: 11.0.16, vendor: Debian, runtime:
> > /usr/lib/jvm/java-11-openjdk-amd64
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "5.10.0-17-amd64", arch: "amd64", family: "unix"
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
