Thanks for the update Bruno :-) I wish both dependabot and the maven dependency plugin took into account Java versions...
Gary On Sat, May 21, 2022, 18:40 Bruno Kinoshita <ki...@apache.org> wrote: > Ah, good point. I saw builds in other projects failing, and the PR's being > closed due to the upgrade, but looks like Text's GH Actions set up needs to > be fixed too. The build for checkstyle passed (even though it appears to > include Java 8), maybe it's not calling checkstyle. > > https://github.com/apache/commons-text/pull/327/checks > > I will revert it and update the GH workflows to include checkstyle with > each JVM version. > > Thanks Gary! > Bruno > > On Sun, 22 May 2022 at 01:48, Gary Gregory <garydgreg...@gmail.com> wrote: > > > -1 > > > > Please stop updating checkstyle to 10.2 because it breaks the build as > > 10.2 requires Java 11. > > > > Gary > > > > On Fri, May 20, 2022 at 7:04 PM <ki...@apache.org> wrote: > > > > > > This is an automated email from the ASF dual-hosted git repository. > > > > > > kinow pushed a commit to branch master > > > in repository https://gitbox.apache.org/repos/asf/commons-text.git > > > > > > > > > The following commit(s) were added to refs/heads/master by this push: > > > new 2450b5bf Bump checkstyle from 9.3 to 10.2 > > > 2450b5bf is described below > > > > > > commit 2450b5bfc0460e22e86e33e517f4944ade33573b > > > Author: dependabot[bot] <49699333+dependabot[bot]@ > > users.noreply.github.com> > > > AuthorDate: Fri May 20 20:03:05 2022 +0000 > > > > > > Bump checkstyle from 9.3 to 10.2 > > > > > > Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from > > 9.3 to 10.2. > > > - [Release notes]( > https://github.com/checkstyle/checkstyle/releases) > > > - [Commits]( > > > https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.2 > > ) > > > > > > --- > > > updated-dependencies: > > > - dependency-name: com.puppycrawl.tools:checkstyle > > > dependency-type: direct:production > > > update-type: version-update:semver-major > > > ... > > > > > > Signed-off-by: dependabot[bot] <supp...@github.com> > > > --- > > > pom.xml | 2 +- > > > src/changes/changes.xml | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/pom.xml b/pom.xml > > > index 24a06cef..ed92f57b 100644 > > > --- a/pom.xml > > > +++ b/pom.xml > > > @@ -48,7 +48,7 @@ > > > > > > <commons.scmPubCheckoutDirectory>site-content</commons.scmPubCheckoutDirectory> > > > > > > <checkstyle.plugin.version>3.1.2</checkstyle.plugin.version> > > > - <checkstyle.version>9.3</checkstyle.version> > > > + <checkstyle.version>10.2</checkstyle.version> > > > > > > > > > <commons.spotbugs.plugin.version>4.6.0.0</commons.spotbugs.plugin.version> > > > > <commons.spotbugs.impl.version>4.7.0</commons.spotbugs.impl.version> > > > diff --git a/src/changes/changes.xml b/src/changes/changes.xml > > > index eca43f0a..3d53e762 100644 > > > --- a/src/changes/changes.xml > > > +++ b/src/changes/changes.xml > > > @@ -79,7 +79,7 @@ The <action> type attribute can be > > add,update,fix,remove. > > > <action type="update" dev="kinow" > > due-to="Dependabot">Bump actions/checkout from v1 to 3 #138, #146, #165, > > #183, #274, #279, #304.</action> > > > <action type="update" dev="kinow" > > due-to="Dependabot">Bump actions/cache from v2 to v2.1.6 #205 #217 > > #234.</action> > > > <action type="update" dev="kinow" > > due-to="Dependabot">Bump github/codeql-action from 1 to 2 #319.</action> > > > - <action type="update" dev="ggregory" > > due-to="Dependabot">Bump checkstyle from 8.34 to 9.3, #141, #168, #182, > > #188, #193, #201, #208, #211, #228, #235, #245, #253, #255, #262, #270, > > #280, #287, #299, #315, #321.</action> > > > + <action type="update" dev="ggregory" > > due-to="Dependabot">Bump checkstyle from 8.34 to 10.2, #141, #168, #182, > > #188, #193, #201, #208, #211, #228, #235, #245, #253, #255, #262, #270, > > #280, #287, #299, #315, #321, #327.</action> > > > <action type="update" dev="ggregory" due-to="Gary > > Gregory, Dependabot">Bump spotbugs-maven-plugin from 4.0.0 to 4.6.0.0, > > #144, #150, #167, #176, #194, #210, #223, #250, #268, #273, #277, #278, > > #286, #293, #303, #320.</action> > > > <action type="update" dev="ggregory" > > due-to="Dependabot">Bump mockito-inline from 3.4.4 to 4.5.1, #143, #148, > > #149, #152, #153, #154, #158, #159, #166, #177, #180, #187, #195, #197, > > #207, #216, #231, #236, #237, #243, #258, #259, #260, #261, #272, #285, > > #291, #305, #317.</action> > > > <action type="update" dev="kinow" > > due-to="Dependabot">Bump junit-jupiter from 5.6.2 to 5.8.2 #163, #204, > > #232, #265, #269, #288.</action> > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > >
