Reviewed about 1/4 of the PR, but it was mainly about serialization (started from the bottom, comparing using GitHub UI [1]). But that code and tests were looking OK.
Will try to go over a few more files, but I also found a PDF in the issue that I think I will try to read first, to have a better idea of the change. I haven't read/used anything related to genetic algorithms since university. Cheers Bruno [1] https://github.com/apache/commons-math/compare/master..feature__MATH-1563__genetic_algorithm On Tuesday, 4 January 2022, 08:57:15 am NZDT, Gilles Sadowski <gillese...@gmail.com> wrote: Hello. I've just created a "feature__MATH-1563__genetic_algorithm" branch[1] in the git repository, with the code provided by Avijit Basak in PR #200, a proposed replacement of the "o.a.c.math4.legacy.genetics" package.[2] Reviews welcome. Regards, Gilles [1] https://gitbox.apache.org/repos/asf?p=commons-math.git;a=shortlog;h=refs/heads/feature__MATH-1563__genetic_algorithm [2] https://issues.apache.org/jira/browse/MATH-1563 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
