On Fri, 13 Aug 2021 at 14:19, Matt Juntunen <matt.a.juntu...@gmail.com>
wrote:
> In addition to the issues that Alex found, I also noticed that the
> commons-geometry-io-euclidean module was completely missing NOTICE and
> LICENSE files. So, I'm going to cancel this vote and try again with
> RC2.
>
> Unless someone thinks it is a blocker, I'm going to defer any changes
> related to the PMD reports until after the release. All of the issues
> are priority 3 and below.
>
Hi Matt,
Can you disable the confusing ternary rule in PMD. This is the main
offender and when looking at the code it is often of the pattern:
Object o;
if (o != null && o.someMethod) {
I do not have an issue with this as it is arranging the common use case
first where the object is likely not null.
Disabling this rule will allow the rest of the PMD report to be more easily
scanned. It can always be reinstated later.
Alex
