Hi Matt,

I've just started looking at this so I will not vote yet but I have found a
few issues.

I did not have 'svn' on my laptop so running 'mvn site' fails. I installed
'svn' and then I get the issue that the entire site is downloaded for all
the modules. I solved this problem in RNG by altering the command to only
do a top level svn checkout for the parent directory. This is done in the
pom profiles 'is-child-module', 'setup-checkout' and 'clean-checkout'. It
fixes the large download of the site. I've just pushed a fix to correct
the site download if svn is not available.

The NOTICE.txt file has 2020 as the year.

I'll try the build on a few machines and let you know if there are any
further issues.

Alex



On Thu, 12 Aug 2021 at 16:41, Matt Juntunen <matt.a.juntu...@gmail.com>
wrote:

> We have completed initial development work on Apache Commons Geometry,
> so I would like to release Apache Commons Geometry (full distribution)
> 1.0.
>
> Apache Commons Geometry (full distribution) 1.0 RC1 is available for
> review here:
>     https://dist.apache.org/repos/dist/dev/commons/geometry/1.0-RC1
> (svn revision 49476)
>
> The Git tag commons-geometry-1.0-rc1 commit for this RC is
> 61ea6625233d2e46b805f009ec9e6cb6340d5e65 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=commit;h=61ea6625233d2e46b805f009ec9e6cb6340d5e65
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-geometry.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-geometry.git--branch>
> commons-geometry-1.0-rc1 commons-geometry-1.0-rc1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1561/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Wed Aug 11 23:20:33 EDT 2021
>
> commons-geometry-1.0-bin.tar.gz=4e8fac99bdc31e9eeef76b614cbbfe7b2ab3db75578f4ab302c7d4b9ec70330c6be0bd8fd5683fd131784eb79b8e5547f954f4e24b3c54d778fc18cea53f49f3
>
> commons-geometry-1.0-bin.zip=766a1f6c5b9441c0eed3ae76a4b5c102c708b2b7cd9b3366b1cacdff2fd7d33abb06948cc49b5e80e8af3e06c7eb24b24d26e0c537260955eb97ce8307d505c2
>
> commons-geometry-1.0-src.tar.gz=6232b8e88589e85b95e4a31ab89b45af97ec09df71f350d2de56197035f3a9b5cfa9ac1e682282c7417a8ccbb7f31ccefb9c903a38ee4e9ebb796777563cdf28
>
> commons-geometry-1.0-src.zip=5bae090d946e0d43b53108b6e9f3edf07dcff74932ea0f9ec8f5c4b9848ca559c434967fb00b0fc90e287d699e4243f0def5764e3eb5decc1abf4f2ecfefc238
>
>
> (no need for .asc hashes!)
>
> I have tested this with ***'mvn clean install site'*** using:
> ***
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
> 2018-02-24T14:49:05-05:00)
> Maven home: /home/matt/tools/maven/apache-maven-3.5.3
> Java version: 1.8.0_292, vendor: Private Build
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-80-generic", arch: "amd64", family:
> "unix"
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Users\mjuntune\tools\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_291, vendor: Oracle Corporation, runtime:
> C:\Program Files\Java\jdk1.8.0_291\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> ***
>
> Details of changes since 1.0-beta1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/geometry/1.0-RC1/RELEASE-NOTES.txt
>
> Site:
>     https://home.apache.org/~mattjuntunen/commons-geometry-1.0-RC1-site/
>     (note some *relative* links are broken and the 1.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to ${commons.bc.version}):
>     N/A
>
> JApiCmp Report (compared to ${commons.bc.version}):
>     N/A
>
> RAT Report:
>
> https://home.apache.org/~mattjuntunen/commons-geometry-1.0-RC1-site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Matt Juntunen,
> Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-geometry.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-geometry.git--branch>
> commons-geometry-1.0-rc1 commons-geometry-1.0-rc1
> cd commons-geometry-1.0-rc1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which
> you then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page
> which you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page
> which you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Reply via email to