On 16/08/2020 16:45, Xeno Amess wrote: >> I've pushed change to the pom which allows compilation on Java14. > > Well it might be silly to ask but, is there a mechanism for us to make sure > that openjdk 6 output jar of this repo can be run totally correct on newer > JVM s?
As per the email you replied to, Seb configured Animal sniffer to check this. Mark > sebb <seb...@gmail.com> 于2020年8月16日周日 下午11:37写道： > >> I've also updated LOGGING to build on Java12+ >> >> The animal-sniffer signature should catch incompatible changes. >> >> AFAICT there is therefore no need to change the minimum version merely >> to make CI easier. >> >> On Sun, 16 Aug 2020 at 16:05, Mark Thomas <ma...@apache.org> wrote: >>> >>> On 16/08/2020 15:45, sebb wrote: >>>> I've pushed change to the pom which allows compilation on Java14. >>>> >>>> Will that suffice? >>> >>> That certainly works for me. Thanks for doing this. >>> >>> Mark >>> >>> >>>> >>>> On Sun, 16 Aug 2020 at 15:29, sebb <seb...@gmail.com> wrote: >>>>> >>>>> On Sun, 16 Aug 2020 at 11:13, Xeno Amess <xenoam...@gmail.com> wrote: >>>>>> >>>>>> I suddenly arise a good idea... >>>>>> How about >>>>>> 1. we release a java 7 version of this repo. >>>>>> 2. we wait for user argue about this. >>>>> >>>>> That has already happened ... >>>>> >>>>> As noted earlier in this thread, Tomcat needs a version that compiles >> on Java 6 >>>>> >>>>>> 3. if no users argue about this, we just go forward to 7. >> Otherwise, we >>>>>> re-consider about this. >>>>> >>>>> >>>>>> >>>>>> Mark Thomas <ma...@apache.org> 于 2020年8月16日周日 下午6:08写道： >>>>>> >>>>>>> On 15/08/2020 19:00, Gary Gregory wrote: >>>>>>>> On Sat, Aug 15, 2020 at 1:14 PM Mark Thomas <ma...@apache.org> >> wrote: >>>>>>>> >>>>>>>>> On 10/08/2020 17:26, Gary Gregory wrote: >>>>>>>>>> As recently done for [EMAIL], I propose we update [LOGGING] and >>>>>>> [DAEMON] >>>>>>>>>> from Java 6 to 7 to streamline building on CIs. >>>>>>>>> >>>>>>>>> -1 for DAEMON. Tomcat 7 depends on it and has a specification >> mandated >>>>>>>>> requirement to run on Java 6. >>>>>>>>> >>>>>>>> >>>>>>>> Yikes ;-) how long is rein in antiquity planned to last? ;-) >>>>>>> >>>>>>> Tomcat 7 EOL is 31 March 2021. >>>>>>> >>>>>>> Like most major Tomcat versions, it has been supported for ~10 years >>>>>>> since the first release. >>>>>>> >>>>>>> The scary thing is that the users mailing list still sees questions >>>>>>> about Tomcat 6 and earlier. >>>>>>> >>>>>>>> We might need a branch for Tomcat so the project can move ahead in >> a more >>>>>>>> modern setting IMO. >>>>>>> >>>>>>> Unless there is a feature that NEEDS Java 7, branching is just >> going to >>>>>>> create unnecessary overhead. My experience of DAEMON over that last >> few >>>>>>> years is the most (all?) of the work has been on the native code >> side. >>>>>>> Therefore, I don't see the harm in keeping the Java side on 1.6 for >> now. >>>>>>> >>>>>>> If the issue is the inability to build with newer Java versions, I >> have >>>>>>> no issue updating the declared minimum version as long as the Java >> code >>>>>>> remains compilable with/for Java 6. >>>>>>> >>>>>>> Mark >>>>>>> >>>>>>>> >>>>>>>> Gary >>>>>>>> >>>>>>>>> >>>>>>>>> Are there any features / bugs in Jira that require this increase? >>>>>>>>> >>>>>>>>> Mark >>>>>>>>> >>>>>>>>> >> --------------------------------------------------------------------- >>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>> >>>>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
