On 18/02/2020 03:06, Matt Juntunen wrote:
Hi Alex,

Thanks for the updates on this. FYI, the current geometry build fails due to a 
missing import: 
https://travis-ci.org/apache/commons-geometry/jobs/651768129#L3806.
Hi,

After a bit of fixing I have green lights on travis.

I noticed that the travis file was using the default script which was 'mvn test'. This means it was not running the check targets for PMD, spotbugs and checkstyle. When I changed it to use the default goal in the POM will all the developer checks then it all broke since the build matrix has Java 13 and EA. These are not in numbers and thus the same configuration that works for numbers had to be corrected.

This fix was an upgrade to spotbugs to support java 13 and the effective disabling of java EA since spotbugs has a dependency on a version of groovy that does not work on java 14.

The PMD violations are down a bit from earlier with some updates from me and a few PMD exclusions:

[INFO] You have 60 PMD violations. For more details see: /home/ah403/git/commons-geometry/commons-geometry-core/target/pmd.xml [INFO] You have 124 PMD violations. For more details see: /home/ah403/git/commons-geometry/commons-geometry-euclidean/target/pmd.xml [INFO] You have 6 PMD violations. For more details see: /home/ah403/git/commons-geometry/commons-geometry-enclosing/target/pmd.xml [INFO] You have 67 PMD violations. For more details see: /home/ah403/git/commons-geometry/commons-geometry-spherical/target/pmd.xml [INFO] You have 8 PMD violations. For more details see: /home/ah403/git/commons-geometry/commons-geometry-hull/target/pmd.xml

Alex



-Matt
________________________________
From: Alex Herbert <alex.d.herb...@gmail.com>
Sent: Monday, February 17, 2020 7:18 PM
To: Commons Developers List <dev@commons.apache.org>
Subject: [geometry] PMD failures

I’ve just updated PMD and checkstyle on [rng], [numbers] and [geometry]. After 
a few glitches I have fixed [rng] and [numbers].

[geometry] has a lot of PMD issues:

[INFO] You have 64 PMD violations. For more details see: 
/Users/ah403/git/commons-geometry/commons-geometry-core/target/pmd.xml
[INFO] You have 244 PMD violations. For more details see: 
/Users/ah403/git/commons-geometry/commons-geometry-euclidean/target/pmd.xml
[INFO] You have 14 PMD violations. For more details see: 
/Users/ah403/git/commons-geometry/commons-geometry-enclosing/target/pmd.xml
[INFO] You have 113 PMD violations. For more details see: 
/Users/ah403/git/commons-geometry/commons-geometry-spherical/target/pmd.xml
[INFO] You have 16 PMD violations. For more details see: 
/Users/ah403/git/commons-geometry/commons-geometry-hull/target/pmd.xml

Many of these are easy to fix such as use of final and literals in condition 
statements.

For now I have disabled the failOnViolation for geometry. After fixing the 
obvious ones we can add exclusions for those items that are deemed fine and 
reinstate PMD to fail on violation.

Alex


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to