Hi Alex, Thanks for the updates on this. FYI, the current geometry build fails due to a missing import: https://travis-ci.org/apache/commons-geometry/jobs/651768129#L3806.
-Matt ________________________________ From: Alex Herbert <alex.d.herb...@gmail.com> Sent: Monday, February 17, 2020 7:18 PM To: Commons Developers List <dev@commons.apache.org> Subject: [geometry] PMD failures I’ve just updated PMD and checkstyle on [rng], [numbers] and [geometry]. After a few glitches I have fixed [rng] and [numbers]. [geometry] has a lot of PMD issues: [INFO] You have 64 PMD violations. For more details see: /Users/ah403/git/commons-geometry/commons-geometry-core/target/pmd.xml [INFO] You have 244 PMD violations. For more details see: /Users/ah403/git/commons-geometry/commons-geometry-euclidean/target/pmd.xml [INFO] You have 14 PMD violations. For more details see: /Users/ah403/git/commons-geometry/commons-geometry-enclosing/target/pmd.xml [INFO] You have 113 PMD violations. For more details see: /Users/ah403/git/commons-geometry/commons-geometry-spherical/target/pmd.xml [INFO] You have 16 PMD violations. For more details see: /Users/ah403/git/commons-geometry/commons-geometry-hull/target/pmd.xml Many of these are easy to fix such as use of final and literals in condition statements. For now I have disabled the failOnViolation for geometry. After fixing the obvious ones we can add exclusions for those items that are deemed fine and reinstate PMD to fail on violation. Alex --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
