> On 15 Jun 2019, at 15:21, sebb <seb...@gmail.com> wrote: > > On Sat, 15 Jun 2019 at 15:14, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> The current master build yields: >> >> [ERROR] CSVFormatTest.testHashCodeAndWithIgnoreHeaderCase:523 >> [ERROR] CSVFormatTest.testWithHeaderComments:972 >> >> I do not think it is OK to push fixes that break the build. > > Already fixed.
I saw that Sebb fixed the issues that caused my PR to fail. These fails are strange as the original PR passed, I modified only comments and formatting following Gary’s review and then it failed on openjdk11, 12 and ea despite having no changes to code logic. I rebased and it is now passing [1]. [1] https://github.com/apache/commons-csv/pull/44 <https://github.com/apache/commons-csv/pull/44> > >> Gary > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org >
