vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r255644566
##########
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##########
@@ -135,3 +96,35 @@ JNIEXPORT jstring JNICALL
Java_org_apache_commons_crypto_OpenSslInfoNative_Nativ
{
return (*env)->NewStringUTF(env, PROJECT_NAME);
}
+
+JNIEXPORT jlong JNICALL
Java_org_apache_commons_crypto_OpenSslInfoNative_OpenSSL
+ (JNIEnv *env, jclass clazz)
+{
+ if (!load_library(env)) {
+ return 0;
+ }
+ if(OPENSSL_VERSION_NUMBER > VERSION_1_1_X){
Review comment:
nit: space after `if` (also in some other places)
Where does `OPENSSL_VERSION_NUMBER` come from? A quick google search seems
to indicate it's a macro in an OpenSSL header. Which makes this a compile time
check, basically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
