vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r255646682
########## File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c ########## @@ -716,3 +677,52 @@ JNIEXPORT void JNICALL Java_org_apache_commons_crypto_cipher_OpenSslNative_clean EVP_CTX_Wrapper *wrapper = CTX_WRAPPER(ctx); free_context_wrapper(wrapper); } + +static int check_update_max_output_len(JNIEnv *env, EVP_CIPHER_CTX *context, jlong ctx, int input_len, int max_output_len) Review comment: All these arguments feel a little redundant. e.g. you don't need `context` since you can just use `wrapper->context`. With some small changes you could also just pass the wrapper directly from the callers, instead of passing the jni env + the pointer address. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
