Hi Oliver,

Thank you for taking your time to review this RC!

Interesting, never paid much attention to what was included in the dist files. 
You are correct, and looks like it is defined in each component's assembly XML 
file (https://github.com/apache/commons-csv/blob/master/src/assembly/bin.xml).
I also think it's not a blocker as I assume previous releases of [csv] also did 
not include the other files. But happy to update the assembly XML files to 
match what others (e.g. [text] and [lang]) include.

Cheers
Bruno


________________________________
From: Oliver Heger <oliver.he...@oliver-heger.de>
To: Commons Developers List <dev@commons.apache.org>
Sent: Wednesday, 30 August 2017, 4:05:08 AM NZST
Subject: Re: [VOTE] Release Apache Commons CSV 1.5 based on RC1

Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and site
look good.

Minor nit: The binary distribution only contains the jar and a
sources-jar. Other components ship with some more artifacts like Javadoc
and test jars. But this is not blocking.

+1

Oliver

Am 27.08.2017 um 12:10 schrieb Bruno P. Kinoshita:
> Hello all,
> 
> This is a [VOTE] for releasing Apache Commons CSV 1.5 (from RC1).
> 
> Tag name:
>   csv-1.5-RC1 (signature can be checked from git using 'git tag -v')
> Tag URL:
>   
> https://git-wip-us.apache.org/repos/asf?p=commons-csv.git;a=commit;h=f76a1357057cd3caaf9b0904d9cc57ce384658a3
> Commit ID the tag points at:
>   f76a1357057cd3caaf9b0904d9cc57ce384658a3
> 
> Site:
>   http://people.apache.org/~kinow/commons-csv-1.5-RC1/
> Distribution files (committed at revision 21311):
>   https://dist.apache.org/repos/dist/dev/commons/csv/
> 
> Distribution files hashes (SHA1):
>   commons-csv-1.5-bin.tar.gz
>   (SHA1: 4c2a4cde27c556f808c9999d354807579a208fcf)
>   commons-csv-1.5-bin.zip
>   (SHA1: fea9c15a06e1f660b2bba30a5fba44a76492c02e)
>   commons-csv-1.5-src.tar.gz
>   (SHA1: e2c83f040fdfdb868184c019624d20b79113e004)
>   commons-csv-1.5-src.zip
>   (SHA1: 22f009e0e7be51c3c61fa667c02ac1822276c7b8)
> 
> These are the Maven artifacts and their hashes:
>   commons-csv-1.5-javadoc.jar
>   (SHA1: 8008b611f677b9ba06988e8102887fa4caed93b5)
>   commons-csv-1.5-sources.jar
>   (SHA1: b76c277916ffef14d63279b896b6a82252ddeb79)
>   commons-csv-1.5-test-sources.jar
>   (SHA1: f7771a23ac6ec7d5183c65146135e51f6bf2c8fb)
>   commons-csv-1.5-tests.jar
>   (SHA1: 1209d9e86a83ac06d139ea02c4331a1426051ee7)
>   commons-csv-1.5.jar
>   (SHA1: e10f140af5b82167640f254fa9d88e35ad74329c)
>   commons-csv-1.5.pom
>   (SHA1: cffa8d9814f6d711a3cb57865e65927b1f54dcb0)
> 
> KEYS file to check signatures:
>   http://www.apache.org/dist/commons/KEYS
> 
> Maven artifacts:
>   https://repository.apache.org/content/repositories/orgapachecommons-1257
> Please select one of the following options[1]:
> 
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
> 
> This vote will be open at least 72 hours, i.e. until 2017-08-30T10:00:00Z 
> (this is UTC time).
> --------
> 
> Cheers,
> 
> -Bruno
> 
> [1] http://apache.org/foundation/voting.html
> ps: I submitted this vote e-mail before at 06:00:00 UTC, but looks like the 
> e-mail did not go through, so waited some hours before sending it again

> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to