Github user ansell commented on a diff in the pull request:

    https://github.com/apache/commons-rdf/pull/30#discussion_r96309778
  
    --- Diff: api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java 
---
    @@ -194,6 +194,114 @@ public void testCreateLiteralLangISO693_3() throws 
Exception {
             assertEquals("\"Herbert Van de Sompel\"@vls", 
vls.ntriplesString());
         }
     
    +    public void testCreateLiteralLangCaseInsensitive() throws Exception {
    +        // COMMONSRDF-51: Literal langtag may not be in lowercase, but
    +        // must be COMPARED (aka .equals and .hashCode()) in lowercase
    +        // as the language space is lower case.       
    +        final Literal lower = factory.createLiteral("Hello", "en-gb"); 
    +        final Literal upper = factory.createLiteral("Hello", "EN-GB"); 
    +        final Literal mixed = factory.createLiteral("Hello", "en-GB");
    +
    +        
    +        assertEquals("en-gb", lower.getLanguageTag().get());
    --- End diff --
    
    RDF4J may not follow this in some cases. It may use the BCP47 normalisation 
conventions to obtain en-GB instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to