On Fri, Dec 19, 2014 at 11:09 AM, sebb <seb...@gmail.com> wrote: > > On 19 December 2014 at 09:17, Thomas Neidhart <thomas.neidh...@gmail.com> > wrote: > > Hi Luc, > > > > tested the artifacts with java version "1.7.0_71". > > Everything looks good, great work. > > > > +1 > > > > @missing revision in vote mail: > > > > from my POV this is really just convenience for the reviewers as *any* > > commit to a branch will be spotted and questioned anyway. > > That's not the point. > > In order to establish provenance, it has to be possible to tie the > files in the source release to a tag in the source repo. > This is the only practical way to establish whether the source has the > correct license. > i.e. the licensing requirements are checked when the file is committed > to the source repo. > It is no feasible to establish licensing directly from the sources in > the RC source archive. >
but writing it in the VOTE mail does not really solve the problem imho. One has still to verify if the created artifacts are actually based on the given branch. btw. of the last 10 vote mails on commons components, > 50% did not have a revision mentioned, and still nobody complained or could not review properly. > > > @NOTICE file: > > > > I fail to understand how adding additional entries (that may not be > > required) can result in a -1 vote. > > http://www.apache.org/dev/licensing-howto.html#mod-notice > > Notice the last (bold) sentence in the section. > It does not contain the phrase *must not* or *shall not*, thus you can argue if it is really mandatory. Furthermore, Commons-Math has already seen several releases with a more or less identical NOTICE file, so this release would certainly not create a precedent. Imho, it would be reasonable to cast a 0- vote, highlight the issue and give the maintainers the chance to fix it after the release. Thomas > > > Thomas > > > > > > On Fri, Dec 19, 2014 at 12:19 AM, Luc Maisonobe <l...@spaceroots.org> > wrote: > >> > >> This is a [VOTE] for releasing Apache Commons Math 3.4. > >> > >> Note that since [math] now uses git, access to the tag is slightly > >> different from other components. To clone a fresh tag, run this command > >> (beware I have split it in 2 lines below): > >> > >> git clone https://git-wip-us.apache.org/repos/asf/commons-math.git \ > >> --branch MATH_3_4_RC1 > >> > >> To verify the tag (as git does sign tags with GPG), use this: > >> > >> cd commons-math > >> git tag -v MATH_3_4_RC1 > >> > >> The site will be available in the staging area, it takes a few hours to > >> transfer from my machine: > >> <http://commons.staging.apache.org/proper/commons-math/> > >> > >> Distribution files: > >> <https://dist.apache.org/repos/dist/dev/commons/math/> > >> > >> Maven artifacts: > >> > >> < > >> > https://repository.apache.org/content/repositories/orgapachecommons-1066/org/apache/commons/commons-math3/3.4/ > >> > > >> > >> > >> [ ] +1 Release it. > >> [ ] +0 Go ahead; I don't care. > >> [ ] -0 There are a few minor glitches: ... > >> [ ] -1 No, do not release it because ... > >> > >> This vote will close in 72 hours, at 2014-12-21T23:15:00Z (this is UTC > >> time). > >> > >> best regards, > >> Luc > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
