2014-10-09 20:54 GMT+02:00 sebb <seb...@gmail.com>: > On 9 October 2014 19:32, Benedikt Ritter <brit...@apache.org> wrote: > > Thank you. I usually copy the description of the PR to make it easier to > > track. I think we haven't agreed on a policy here. What is your opinion? > > It looks odd to me for an enhancement request title to use the past > tense, as the action has not yet happened. >
I think this is the usual way to name PRs at github since they have already taken place in the fork. But I agree with you, that it sounds odd as a JIRA issue title (not sure about change notes). > > It seems to me that typos and grammatical errors should be corrected > in issue titles, as they form part of the release notes and the > website. > yes. > > As far as tracking is concerned, surely it would be better to add a > comment to the PR which includes a link to the JIRA issue. > This shows that the PR has been picked up as well as making it easy > for people reading the PR to find the JIRA issue. > > But if you want to revert the title, go ahead. > No no, I was unsure myself and wanted to hear a native speaker's opinion. > > > 2014-10-09 20:22 GMT+02:00 Sebb (JIRA) <j...@apache.org>: > > > >> > >> [ > >> > https://issues.apache.org/jira/browse/COLLECTIONS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > >> ] > >> > >> Sebb updated COLLECTIONS-533: > >> ----------------------------- > >> Summary: Add a MultiValuedLinkedHashMap to preserve insertion order > >> (was: Added MultiValuedLinkedHashMap to preserve insertion order) > >> > >> > Add a MultiValuedLinkedHashMap to preserve insertion order > >> > ---------------------------------------------------------- > >> > > >> > Key: COLLECTIONS-533 > >> > URL: > >> https://issues.apache.org/jira/browse/COLLECTIONS-533 > >> > Project: Commons Collections > >> > Issue Type: New Feature > >> > Components: Map > >> > Reporter: Benedikt Ritter > >> > Labels: github > >> > > >> > Placeholder ticket for > >> https://github.com/apache/commons-collections/pull/3 > >> > >> > >> > >> -- > >> This message was sent by Atlassian JIRA > >> (v6.3.4#6332) > >> > > > > > > > > -- > > http://people.apache.org/~britter/ > > http://www.systemoutprintln.de/ > > http://twitter.com/BenediktRitter > > http://github.com/britter > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
