Schalk, The only problem I see with the way that you do code reviews on Github, is the fact that you can only review change sets. You can't simply go through an existing codebase and point out the problems. I suggested Stash and Crucible since they're both linked with JIRA, and I think Apache has free access to Atlassian's stack for its projects
Cheers, Mark On Tue, Sep 9, 2014 at 10:15 AM, Schalk Cronj é <ysb...@gmail.com> wrote: > On 09/09/2014 16:57, Mark Fortner wrote: > >> If I had to pick one feature that makes git more useful than svn, it would >> be the ease in creating feature branches. If you want to add a feature, >> you simply create a local branch to implement the feature, implement it, >> and commit it, and create a pull request. If you're using Atlassian's >> Crucible or Stash, it's pretty easy to do a code review of the pull >> request. >> > For me that is the killer feature of Git where it beats Subversion > hands-down. > > Personally I also find that performing a code review of a pull request on > Github easy enough. > > -- > Schalk W. Cronjé > @ysb33r > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
