On 12 February 2014 23:22, Matt Benson <gudnabr...@gmail.com> wrote: > The AL header is in > https://svn.apache.org/repos/asf/commons/proper/commons-parent/trunk/src/changes/release-notes.vm, > from which the release notes were generated.
The header lines in the vm file are comments that are not supposed to be copied to the generated output. Likewise the later lines prefixed with ## How did you generate the RN file? > Interestingly, m2eclipse defaults to the behavior that redundant > groupId/version are warning-worthy. Browsing > http://svn.apache.org/repos/asf/maven seems to show that Apache Maven's own > developers omit the duplicate elements. That does not mean it is best practise for non-plugin development. > Thanks for working on my line endings; apparently one or more of my > machines wasn't/isn't configured properly in that regard. OK. > Matt > > > On Wed, Feb 12, 2014 at 4:49 PM, sebb <seb...@gmail.com> wrote: > >> On 12 February 2014 02:20, Matt Benson <mben...@apache.org> wrote: >> > I would like to make the inaugural release of the [weaver] component. >> > >> > Apache Commons Weaver 1.0 RC1 is available for review at: >> > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4368). >> > >> > Maven artifacts are at: >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1007/. >> > >> > Tested with Oracle JDKs 6 and 7. >> > >> > The Subversion tag is: >> > >> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.0_RC1/(r1567477) >> . >> > >> > Site: >> > http://people.apache.org/~mbenson/commons-weaver-1.0-rc1/index.html >> > >> > RAT Report: >> > >> http://people.apache.org/~mbenson/commons-weaver-1.0-rc1/rat-report.html >> > >> >> I've never seen the AL header in release notes before. >> Not sure that's necessary (and it makes the notes harder to read). >> >> The poms don't include any groupId definitions. >> Although this will default from the parent, I think it is better to >> specify the group id. >> Otherwise it is not clear whether the omission is accidental or deliberate. >> Also if the parent group Id ever changes (or perhaps is removed) the >> component groupId will change unless the groupId is added at that >> point. >> >> > Keys: https://dist.apache.org/repos/dist/release/commons/KEYS >> > >> > Please review the release candidate and vote. >> > This vote will close no sooner that 72 hours from now, i.e. after >> 0300UTC >> > 15-February 2014 >> > >> > [ ] +1 Release these artifacts >> > [ ] +0 OK, but... >> > [ ] -0 OK, but really should fix... >> > [ ] -1 I oppose this release because... >> > >> > Thanks! >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
