Build works fine with JDK 1.7 on Windows 8.1. Artifacts and site look good.
I noticed some problems: - The names of the distributions files contain a -dist suffix, and they also deflate in a directory named -dist. This is not typical for other commons components. - The binary distribution does not contain the release notes. - The jar artifacts contain LICENSE and NOTICE without the .txt extension. - There is a bunch of checkstyle errors. For an initial release it would be good to start with a clean code base. - From the documentation on the site it is hard to get an understanding what this component does and how it can be used in practice. Maybe a short "getting started guide" or "some steps to start your project" would be helpful (I know this is much work to do and less fun than coding). Most of these points are minor. I think at least the release notes should be added to the binary distribution - although they do not contain much information for this initial release. Oliver Am 12.02.2014 03:20, schrieb Matt Benson: > I would like to make the inaugural release of the [weaver] component. > > Apache Commons Weaver 1.0 RC1 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4368). > > Maven artifacts are at: > https://repository.apache.org/content/repositories/orgapachecommons-1007/. > > Tested with Oracle JDKs 6 and 7. > > The Subversion tag is: > > http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.0_RC1/(r1567477). > > Site: > http://people.apache.org/~mbenson/commons-weaver-1.0-rc1/index.html > > RAT Report: > http://people.apache.org/~mbenson/commons-weaver-1.0-rc1/rat-report.html > > Keys: https://dist.apache.org/repos/dist/release/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, i.e. after 0300UTC > 15-February 2014 > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
