Am 28.11.2013 09:05, schrieb Thomas Neidhart: > On 11/28/2013 04:09 AM, Damjan Jovanovic wrote: >> Vote closed, results were: >> >> +1: >> Damjan Jovanovic >> >> No other votes were cast. >> >> Vote fails since majority approval needs at least 3 votes of +1 -> >> aborting release. > > Hi Damjan, > > sorry that this vote failed, and I hope you still continue with this > release, I will at least review your next RC! > > @all: something that bothered me while doing the release for collections > 4 and I have seen too for this component: > > While a vote is being cast, people other than the RM should restrain > themselves from making changes to trunk. Even if the intention is just > to help the RM and clean up things, such an action is usually quite > detrimental to the vote itself. > > So I propose the following: > > * cast your vote with suggestions for improvement > * compile your changes as patch and either attach them to an issue > or send them to the RM > > After the vote has ended or cancelled the changes can be included, but > just changing trunk during a vote has the following effect: > > * gives other people the impression that the vote will fail anyway > thus postponing their vote for the next RC > * putting pressure on the RM to cancel the vote as already many > changes have been made to the trunk, even if they are purely of > cosmetic nature > > Imho, cosmetic or style related changes should *never* block a release. > These are things that can be worked on between releases, so we can > really focus on the important things during the release procedure. > > If things are not perfect, just make another release a month later that > tidies up all the source code. We always say: release early, release > often, but in fact we never do that, the credo is always: release perfect.
Yes, I second that. For me commits on a component that is currently voted for a release have the effect you described. I am confused whether it makes sense to review and vote as it seems that the vote is going to fail anyway. Oliver > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
