On 11/26/13, 12:40 PM, Mark Thomas wrote: > On 26/11/2013 16:17, Phil Steitz wrote: >> On 11/26/13, 4:09 AM, Mark Thomas wrote: >>> On 25/11/2013 23:30, Phil Steitz wrote: >>>> On 11/25/13, 3:17 PM, Gary Gregory wrote: >>>>> Are we getting a 2.0.1 for this fix? >>>> GKOP still needs to be fixed to resolve this and the GOP fix needs >>>> the "TR" part of "CTR" done carefully ;). >>> The GOP fix looks OK to me. >>> >>> Good catch with invalidateObject(). I hadn't noticed that. >> I just committed a fix for GKOP. I thought about just changing the >> returnObject code to always call reuseCapacity instead of >> immediately returning after destroying an object; but reuseCapacity >> is a weaker liveness-enabler. Calling addObject with the key of the >> instance just destroyed seemed more reliable. > Patch looks good to me. > > I noticed a minor inconsistency in the GOP code that I fixed. It wasn't > a functional change but I think it helps to have the code as consistent > as possible to aid understanding.
Thanks for fixing that. Sorry I missed it. > >> I am right that destroys on activation or validation failures during >> borrow can't trigger this problem, right? > That shouldn't trigger this problem. If the activation or validation > fails then that will be followed by a call to create. > >> Might be good to add test >> cases for this in any case. I will get to that eventually, but if >> this fix passes review I am OK resolving the issue. > I'm fine with resolving it too. OK, thanks. Phil > > Mark > > >> Phil >>> Mark >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
