My +1 below stands, but here is something for the RM (Mark) and
others to consider.
Following the directions on the main site page, I realized that the
change in r 1537253 to break the cyclic dependency between .pool2
and .pool2.impl made my instructions incorrect. I did not fully get
the implications of this change when it was committed and I failed
to make the appropriate change to the site doc. I can update the
site post-release no problem; but I wonder now if we might want to
consider moving DefaultPooledObject up to .pool2 so that the simple
(now incomplete) approach documented on the main page can work.
Otherwise, you always have to add the wrap implementation, which I
bet in the vast majority of cases will end up just being what
makeObject did before the change:
@Override
public PooledObject<Foo> wrap(Foo foo) {
return new DefaultPooledObject<Foo>(foo);
}
I get that DefaultPooledObject is an impl kind of thing; but so
actually is BasePooledObjectFactory.
Apologies - once again - for not having noticed this when reviewing
the commit and RCs. I can live with it the way it is and as I said
the site doc can be fixed post-release, so I am OK moving forward.
Just wanted to do a little gut check before we pour the cement on
this setup.
Phil
On 11/6/13 8:05 AM, Phil Steitz wrote:
> +1
>
> Thanks, Mark!
>
> Phil
>
> On 11/4/13 4:28 PM, Mark Thomas wrote:
>> A change to the component id to pool2 required a new RC. The only other
>> change was some improvements to the Ant build.
>>
>>
>> The Pool 2.0 RC4 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/pool/ (r3419)
>>
>> Maven artifacts are here:
>> https://repository.apache.org/content/repositories/orgapachecommons-073/
>>
>> Details of changes since 1.6 are in the release notes and changelog:
>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> http://people.apache.org/~markt/dev/commons-pool-2.0-RC4/changes-report.html
>>
>> The tag is here:
>> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_0_RC4/
>> (r 1538827)
>>
>> Site:
>> http://people.apache.org/~markt/dev/commons-pool-2.0-RC4
>> (Broken links to Javadoc versions expected)
>>
>> KEYS:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>>
>> Cheers,
>>
>> Mark
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
