On Wed, Oct 16, 2013 at 10:05 AM, Christian Grobmeier <grobme...@gmail.com>wrote:
> Hi, > > [X] +1 Release these artifacts > > > On 16 Oct 2013, at 15:20, Gary Gregory wrote: > >> Thank you Stefan for the new RC. >> > > +1 > > Maybe I have interpreted the Clirr report wrong. But besides the two > buffer fields it doesn't look so bad (just additions). I believe these two > fields are acceptable although I understand people might want to discuss > the version number again. I will wait what Garys findings are. In this case, I was only talking about the removal of the protected fields. Method additions so common as to warrant this note on our site: https://commons.apache.org/releases/versioning.html#note1 I'll have to blog about "Extreme Versioning" at some point, off topic here. > > These are not blockers but I was expecting all of the _new_ 7z code to >> be warning-free (with my IDE settings that is) in the sense that there >> should be no missing Javadoc (there are missing @throws tags for >> example) and no FindBugs issues (there is one, easy to fix), same for >> PMD, CPD. >> > … > >> IMO, all empty blocks should be commented. >> > > Actually I don't see this as urgent enough to block a release. Neither do I which is why I started with "These are not blockers but..." ;) Gary > Creating a RC is always time consuming. > And I don't consider javadoc as important enough to be completed. Btw, I > like this post very much: > http://vafer.org/blog/**20050323095453/<http://vafer.org/blog/20050323095453/> > > I agree code *should* be warning free. While this RC is surely not > perfect, its not that bad the we need > to re-roll the release (I checked the findbugs, pmd, cpd reports) > > Cheers > Christian > > > > > >> Gary >> >> On Tue, Oct 15, 2013 at 2:26 PM, Stefan Bodewig <bode...@apache.org> >> wrote: >> >>> Hi all, >>> >>> I've addressed most of the issues brought up during the RC1 vote. I'll >>> have limited net time the next three days, but hopefully I won't be >>> needed. >>> >>> Stefan >>> >>> Compress 1.6 RC2 is available for review here: >>> >>> https://dist.apache.org/repos/**dist/dev/commons/compress/<https://dist.apache.org/repos/dist/dev/commons/compress/> >>> (svn revision 3272) >>> >>> Maven artifacts are here: >>> https://repository.apache.org/**content/repositories/** >>> orgapachecommons-178/org/**apache/commons/commons-**compress/1.6/<https://repository.apache.org/content/repositories/orgapachecommons-178/org/apache/commons/commons-compress/1.6/> >>> >>> Details of changes since 1.4 are in the release notes: >>> >>> http://people.apache.org/~**bodewig/cc-1.6/RELEASE-NOTES.**txt<http://people.apache.org/~bodewig/cc-1.6/RELEASE-NOTES.txt> >>> >>> http://people.apache.org/~**bodewig/cc-1.6/site/changes-**report.html<http://people.apache.org/~bodewig/cc-1.6/site/changes-report.html> >>> >>> The tag is here: >>> http://svn.apache.org/repos/**asf/commons/proper/compress/** >>> tags/COMPRESS-1.6-RC2/<http://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.6-RC2/> >>> (svn revision 1532449) >>> >>> Site: >>> >>> http://people.apache.org/~**bodewig/cc-1.6/site/<http://people.apache.org/~bodewig/cc-1.6/site/> >>> >>> Clirr Report (compared to 1.5): >>> >>> http://people.apache.org/~**bodewig/cc-1.6/site/clirr-**report.html<http://people.apache.org/~bodewig/cc-1.6/site/clirr-report.html> >>> >>> RAT Report: >>> >>> http://people.apache.org/~**bodewig/cc-1.6/site/rat-**report.html<http://people.apache.org/~bodewig/cc-1.6/site/rat-report.html> >>> >>> KEYS: >>> http://www.apache.org/dist/**commons/KEYS<http://www.apache.org/dist/commons/KEYS> >>> >>> Please review the release candidate and vote. >>> This vote will close no sooner that 72 hours from now, i.e. after 1830 >>> GMT 18-October 2013 >>> >>> [ ] +1 Release these artifacts >>> [ ] +0 OK, but... >>> [ ] -0 OK, but really should fix... >>> [ ] -1 I oppose this release because... >>> >>> ------------------------------**------------------------------** >>> --------- >>> To unsubscribe, e-mail: >>> dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org> >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> JUnit in Action, Second Edition >> Spring Batch in Action >> Blog: http://garygregory.wordpress.**com<http://garygregory.wordpress.com> >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> ------------------------------**------------------------------**--------- >> To unsubscribe, e-mail: >> dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org> >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > --- > http://www.grobmeier.de > @grobmeier > GPG: 0xA5CC90DB -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
