Hi All:
Thank you Stefan for the new RC.
Now that we have a new cleaned up RC, I want to make sure that we
understand that, strictly speaking and while unlikely in practice,
1.6-RC2 breaks binary compatibility with 1.5 (see Clirr). I think we
started discussing this and after some hand-waving some folks are OK
with it. I'm not comfortable with it due to getting bitten in large
integration projects by issues like this and jar hell balls. I'll
likely defer to the SMEs here but I just want to double check
specifically on this RC vote thread and hear back before I vote.
These are not blockers but I was expecting all of the _new_ 7z code to
be warning-free (with my IDE settings that is) in the sense that there
should be no missing Javadoc (there are missing @throws tags for
example) and no FindBugs issues (there is one, easy to fix), same for
PMD, CPD.
I also would like to see mystery code commented like
org.apache.commons.compress.archivers.sevenz.BoundedRandomAccessFileInputStream.close():
@Override
public void close() {
}
like:
@Override
public void close() {
// do nothing because...
}
IMO, all empty blocks should be commented.
Gary
On Tue, Oct 15, 2013 at 2:26 PM, Stefan Bodewig <bode...@apache.org> wrote:
> Hi all,
>
> I've addressed most of the issues brought up during the RC1 vote. I'll
> have limited net time the next three days, but hopefully I won't be
> needed.
>
> Stefan
>
> Compress 1.6 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/compress/
> (svn revision 3272)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-178/org/apache/commons/commons-compress/1.6/
>
> Details of changes since 1.4 are in the release notes:
> http://people.apache.org/~bodewig/cc-1.6/RELEASE-NOTES.txt
> http://people.apache.org/~bodewig/cc-1.6/site/changes-report.html
>
> The tag is here:
>
> http://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.6-RC2/
> (svn revision 1532449)
>
> Site:
> http://people.apache.org/~bodewig/cc-1.6/site/
>
> Clirr Report (compared to 1.5):
> http://people.apache.org/~bodewig/cc-1.6/site/clirr-report.html
>
> RAT Report:
> http://people.apache.org/~bodewig/cc-1.6/site/rat-report.html
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. after 1830
> GMT 18-October 2013
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
JUnit in Action, Second Edition
Spring Batch in Action
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
