On Tue, Aug 6, 2013 at 10:38 AM, sebb <seb...@gmail.com> wrote: > On 6 August 2013 15:32, Benedikt Ritter <brit...@apache.org> wrote: > > 2013/8/6 Gary Gregory <garydgreg...@gmail.com> > > > >> On Tue, Aug 6, 2013 at 10:19 AM, James Carman < > ja...@carmanconsulting.com > >> >wrote: > >> > >> > I was trying to emphasize "all". > >> > > >> > >> Then, yes, except Lexer which is currently subclassed by alternate test > >> implementations. > >> > >> Do we still need those subclasses? > >> > > > > IMHO they don't make much sense, since they use the current trunk Lexer > as > > base. If we really want to compare the performance of the current trunk > to > > older revisions, we can simply checkout a complete revision instead of > only > > testing only part of the code. > > > > Originally they were quite useful, but I agree they can now be deleted. > > But I would keep the (disabled) test cases that use them. >
Just to be clear then, these would be removed: org.apache.commons.csv.CSVLexer1 org.apache.commons.csv.CSVLexer1306663 org.apache.commons.csv.CSVLexer1306667 org.apache.commons.csv.CSVLexer3 Gary > > > > >> > >> Gary > >> > >> > >> > > >> > On Tuesday, August 6, 2013, Gary Gregory wrote: > >> > > >> > > On Tue, Aug 6, 2013 at 8:43 AM, James Carman < > >> ja...@carmanconsulting.com > >> > <javascript:;> > >> > > >wrote: > >> > > > >> > > > I am also -0 to this idea in general. Are we talking about > literally > >> > > > making all classes final? > >> > > > > >> > > > >> > > What is the difference between a class that is literally final and > >> > > figuratively final? ;) > >> > > > >> > > Gary > >> > > > >> > > > >> > > > > >> > > > On Tuesday, August 6, 2013, Gary Gregory wrote: > >> > > > > >> > > > > I think the idea is that it promotes composition instead of > >> > > > > subclassing as the extension pattern. > >> > > > > > >> > > > > If I wanted the parser to produce a different kind of record, > >> > > > > > >> > > > > Gary > >> > > > > > >> > > > > On Aug 6, 2013, at 4:44, Emmanuel Bourg <ebo...@apache.org > >> > <javascript:;> > >> > > <javascript:;>> > >> > > > > wrote: > >> > > > > > >> > > > > > Le 05/08/2013 19:34, Gary Gregory a écrit : > >> > > > > > > >> > > > > >> Thoughts? > >> > > > > > > >> > > > > > -0, that's not very friendly to people willing to extend > [csv]. > >> > > > > > > >> > > > > > Emmanuel Bourg > >> > > > > > > >> > > > > > > >> > > > > > > >> > --------------------------------------------------------------------- > >> > > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> > <javascript:;> > >> > > > <javascript:;> > >> > > > > > For additional commands, e-mail: dev-h...@commons.apache.org > >> > <javascript:;> > >> > > > <javascript:;> > >> > > > > > > >> > > > > > >> > > > > > >> --------------------------------------------------------------------- > >> > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> > <javascript:;> > >> > > <javascript:;> > >> > > > > For additional commands, e-mail: dev-h...@commons.apache.org > >> > <javascript:;> > >> > > > <javascript:;> > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > E-Mail: garydgreg...@gmail.com <javascript:;> | ggreg...@apache.org > >> > <javascript:;> > >> > > Java Persistence with Hibernate, Second Edition< > >> > > http://www.manning.com/bauer3/> > >> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > >> > > Spring Batch in Action <http://www.manning.com/templier/> > >> > > Blog: http://garygregory.wordpress.com > >> > > Home: http://garygregory.com/ > >> > > Tweet! http://twitter.com/GaryGregory > >> > > > >> > > >> > >> > >> > >> -- > >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > >> Java Persistence with Hibernate, Second Edition< > >> http://www.manning.com/bauer3/> > >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > >> Spring Batch in Action <http://www.manning.com/templier/> > >> Blog: http://garygregory.wordpress.com > >> Home: http://garygregory.com/ > >> Tweet! http://twitter.com/GaryGregory > >> > > > > > > > > -- > > http://people.apache.org/~britter/ > > http://www.systemoutprintln.de/ > > http://twitter.com/BenediktRitter > > http://github.com/britter > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
