Hi Gary, nice to see some activity in CSV again. We were talking about reverting CSVFormat back to the old API that does not use the builder pattern, see CSV-99[1]. We still have 18 unresolved issues. I think we should go through all those issues and decide if we want to have them in 1.0.
Regarding your commit: I'm not sure whether an NPE can actually happen at that point. The last character was a line break and the current character is a comment start. So read line should at least return the comment start. Benedikt [1] https://issues.apache.org/jira/browse/CSV-99 2013/6/21 Gary Gregory <garydgreg...@gmail.com> > [oops, send previous msg too soon] > > FIndBugs reports: Immediate dereference of the result of readLine() in > org.apache.commons.csv.CSVLexer.nextToken(Token) at line 89. > > Which I addressed in SVN but wanted to check with the ML just in case... > > Gary > > > > > > On Thu, Jun 20, 2013 at 10:28 AM, Gary Gregory <garydgreg...@gmail.com > >wrote: > > > So... what are the remaining issues before 1.0? > > > > Are we happy with the current state of the API? Builder and all? > > > > Gary > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition< > http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition< > http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
