On Sun, Mar 3, 2013 at 3:32 PM, sebb <seb...@gmail.com> wrote: > On 3 March 2013 13:25, <brit...@apache.org> wrote: >> Author: britter >> Date: Sun Mar 3 13:25:24 2013 >> New Revision: 1452037 >> >> URL: http://svn.apache.org/r1452037 >> Log: >> Add JavaDoc and SVN Keywords > > -1 > > Please don't use $Date$ - it is rendered using the client Locale, and > so causes problems matching SVN tags against source archives. > > $Revision$ is usally enough; if you really want a date, use $id$
I would just like to say that this is very heavy handed vetoing a change like this over something that is so trivial. It is also an invalid veto IMO because this is purely documentation AND it is only a question of style. I would seriously advise you to be more circumspect in how you chose to cast a veto. Also, to Benedikt - remember this is a volunteer organisation and you get to chose where you spend your volunteer hours. Unfortunately only Sebb can withdraw his veto, but if I was you I would be saying to Sebb "OK feel free to revert or change it if you wish" Niall >> Modified: >> >> commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java >> (contents, props changed) >> >> Modified: >> commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java?rev=1452037&r1=1452036&r2=1452037&view=diff >> ============================================================================== >> --- >> commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java >> (original) >> +++ >> commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java >> Sun Mar 3 13:25:24 2013 >> @@ -22,6 +22,15 @@ import java.util.ArrayList; >> >> import junit.framework.TestCase; >> >> +/** >> + * getPropertyType return null on second descendant class >> + * >> + * <p /> >> + * See https://issues.apache.org/jira/browse/BEANUTILS-422 >> + * <p /> >> + * >> + * @version $Revision$ $Date$ >> + */ >> public class Jira422TestCase extends TestCase { >> >> public void testRootBean() throws Exception { >> >> Propchange: >> commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java >> ------------------------------------------------------------------------------ >> --- svn:keywords (added) >> +++ svn:keywords Sun Mar 3 13:25:24 2013 >> @@ -0,0 +1,2 @@ >> +Revision >> +Date >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org