2013/3/3 sebb <seb...@gmail.com> > On 3 March 2013 19:27, Benedikt Ritter <brit...@apache.org> wrote: > > Hi sebb, > > > > > > 2013/3/3 sebb <seb...@gmail.com> > > > >> On 3 March 2013 13:25, <brit...@apache.org> wrote: > >> > Author: britter > >> > Date: Sun Mar 3 13:25:24 2013 > >> > New Revision: 1452037 > >> > > >> > URL: http://svn.apache.org/r1452037 > >> > Log: > >> > Add JavaDoc and SVN Keywords > >> > >> -1 > >> > >> Please don't use $Date$ - it is rendered using the client Locale, and > >> so causes problems matching SVN tags against source archives. > >> > >> $Revision$ is usally enough; if you really want a date, use $id$ > >> > > > > Thanks for reviewing. I've just aligned the SVN keywords to all the other > > tests in the component. > > Is there a commons wide convention on how to use SVN tags? Please point > me > > to documentation about this and I will change all classes according to > that. > > I don't know if there is documentation, but it was all discussed and > agreed on the dev list a year or so ago. >
Would be nice to have this kind of things documented somewhere in the wiki. I don't want to search the archives before every commit. I have created BEANUTILS-430 [1] because a lot of files contain the $Date$ keyword. Are you okay with this or should I revert the commit anyway? Regards, Benedikt [1] https://issues.apache.org/jira/browse/BEANUTILS-430 > > > If there isn't a convention for all components it has to be discussed for > > beanutils how SVN tags have to be changed. Please start a separate thread > > for this discussion. > > > > TIA! > > Benedikt > > > > > >> > >> > Modified: > >> > > >> > commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java > >> (contents, props changed) > >> > > >> > Modified: > >> > commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java > >> > URL: > >> > http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java?rev=1452037&r1=1452036&r2=1452037&view=diff > >> > > >> > ============================================================================== > >> > --- > >> > commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java > >> (original) > >> > +++ > >> > commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java > >> Sun Mar 3 13:25:24 2013 > >> > @@ -22,6 +22,15 @@ import java.util.ArrayList; > >> > > >> > import junit.framework.TestCase; > >> > > >> > +/** > >> > + * getPropertyType return null on second descendant class > >> > + * > >> > + * <p /> > >> > + * See https://issues.apache.org/jira/browse/BEANUTILS-422 > >> > + * <p /> > >> > + * > >> > + * @version $Revision$ $Date$ > >> > + */ > >> > public class Jira422TestCase extends TestCase { > >> > > >> > public void testRootBean() throws Exception { > >> > > >> > Propchange: > >> > commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java > >> > > >> > ------------------------------------------------------------------------------ > >> > --- svn:keywords (added) > >> > +++ svn:keywords Sun Mar 3 13:25:24 2013 > >> > @@ -0,0 +1,2 @@ > >> > +Revision > >> > +Date > >> > > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > -- > > http://people.apache.org/~britter/ > > http://www.systemoutprintln.de/ > > http://twitter.com/BenediktRitter > > http://github.com/britter > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
