Ops, turns out I had already started a thread [1] about this TODO here in the mailing list. Quoting other names that I had thought:
"GeneratorToCollectionTransformer (...) Listify, Eagerlize and Lazy List Builder." Sorry, [1] http://markmail.org/thread/l552rd6xrr2afcvl Bruno P. Kinoshita http://kinoshita.eti.br http://tupilabs.com ----- Original Message ----- > From: Bruno P. Kinoshita <ki...@apache.org> > To: Commons List <dev@commons.apache.org> > Cc: > Sent: Monday, January 28, 2013 11:22 PM > Subject: [functor] Remove TODO comment from CollectionTransformer > > Hi all, > > The CollectionTransformer in [functor] has the following TODO: > > TODO revisit this class... it could stand a more-descriptive name. Also, > it's a little > hard to say whether, for an instance constructed without a specific target > collection, > #evaluate() should return a new ArrayList for each call, or continue > adding > to > a single ArrayList instance (the current behavior). > Perhaps this is more a documentation issue than anything. > >> it could stand a more-descriptive name. > > I'm okay with the name. What this class does is, for a given generator, it > fills a collection with the generated elements and returns this collection. > Maybe GenetorToCollection? Any thoughts? > >> Also, it's a little > hard to say whether, for an instance constructed without a specific target > collection, > #evaluate() should return a new ArrayList for each call, or continue > adding > to > a single ArrayList instance (the current behavior). > > It used an ArrayList in teh past, but now it uses generics. I believe this > part > of the comment can be ignored. This TODO was mentioned in the last release > vote > too http://markmail.org/message/ythw55yad5lrvqrj > > Thanks in advance > > [1] > Bruno P. Kinoshita > http://kinoshita.eti.br > http://tupilabs.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
