On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson <gudnabr...@gmail.com> wrote:
> Hello, > We'd love to have our whole testsuite updated to JUnit 4, IMO. The > only thing is that as a rule we'd rather that changeset be separate > from another, so I'd recommend providing multiple patches, possibly > submitted in separate JIRA issues. > +1! Patch 1: Update to JUnit 4 Patch 2: the patch Gary > > Matt > > On Mon, Sep 17, 2012 at 12:59 PM, Duncan Jones <dun...@wortharead.com> > wrote: > > Hi, > > > > While working on a patch for LANG-799, I ran into a problem where I > > couldn't use JUnit4 Assume.* methods because the DateUtilsTest.java > > extends TestCase (forcing JUnit3 behaviour), rather than using JUnit4 > > annotations. > > > > Is it rude to adjust this class to use JUnit4 annotations? There seem > > to be other classes that avoid extending TestCase, including > > CompareToBuilderTest.java (whose SVN history shows a previous port to > > using JUnit4 lingo). > > > > I don't want to muddy my patch with a major test code refactory, so > > for now I will work around the missing Assume.* functionality. But I'd > > like to know the approach to take in the future - should I raise a bug > > against a particular test file with a patch to port it? Should there > > be a bug that requests the port of all test files to JUnit4? > > > > Kind regards, > > > > Duncan Jones > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
