Hi, While working on a patch for LANG-799, I ran into a problem where I couldn't use JUnit4 Assume.* methods because the DateUtilsTest.java extends TestCase (forcing JUnit3 behaviour), rather than using JUnit4 annotations.
Is it rude to adjust this class to use JUnit4 annotations? There seem to be other classes that avoid extending TestCase, including CompareToBuilderTest.java (whose SVN history shows a previous port to using JUnit4 lingo). I don't want to muddy my patch with a major test code refactory, so for now I will work around the missing Assume.* functionality. But I'd like to know the approach to take in the future - should I raise a bug against a particular test file with a patch to port it? Should there be a bug that requests the port of all test files to JUnit4? Kind regards, Duncan Jones --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
