On Sun, Sep 2, 2012 at 3:51 PM, sebb <seb...@gmail.com> wrote: > On 2 September 2012 19:45, Gary Gregory <garydgreg...@gmail.com> wrote: > > Hi All: > > > > There has been a recent mini-flury of changes in codec as a release > > candidate is approaching. > > > > Thank you to all the committers and patchers for helping codec move > closer > > to another release. > > > > This coming week or next weekend, I'd like to roll an RC. > > > > Does anyone want to discuss anything or fiddle with code before I > proceed? > > DigestUtils shaHex methods have been deprecated in favour of sha1Hex; > as such I would expect the shaHex implementations to delegate to sha1.
Instead they have their own implementations; it is only by comparison > with the sha1 versions that one can see they are the same. > Done. > > [If this is done, could then consider dropping the shaHex test case.] > I'd like to keep the test to keep the code coverage. We can drop the test when we drop the API in a future major release. > > Also, why is getShaDigest not deprecated in favour of getSha1Digest? > Done. Thank you, Gary > > Still looking at the rest of the code. > > > Thank you, > > Gary > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
