On Sep 2, 2012, at 15:51, sebb <seb...@gmail.com> wrote: > On 2 September 2012 19:45, Gary Gregory <garydgreg...@gmail.com> wrote: >> Hi All: >> >> There has been a recent mini-flury of changes in codec as a release >> candidate is approaching. >> >> Thank you to all the committers and patchers for helping codec move closer >> to another release. >> >> This coming week or next weekend, I'd like to roll an RC. >> >> Does anyone want to discuss anything or fiddle with code before I proceed? > > DigestUtils shaHex methods have been deprecated in favour of sha1Hex; > as such I would expect the shaHex implementations to delegate to sha1. > Instead they have their own implementations; it is only by comparison > with the sha1 versions that one can see they are the same. >
It is not clear to me that calling DigestMessage with "SHA" and "SHA-1" does the same thing because different objects are returned, likely because neither are cached. Because "SHA" is not an official name I did not want to take the risk. If both names are aliases, then we can and should redirect one to the other. > [If this is done, could then consider dropping the shaHex test case.] > > Also, why is getShaDigest not deprecated in favour of getSha1Digest? It should be. That's an omission. Gary > > Still looking at the rest of the code. > >> Thank you, >> Gary >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
