On 9 February 2012 15:00, Gilles Sadowski <[email protected]> wrote: > On Thu, Feb 09, 2012 at 02:46:26PM +0000, sebb wrote: >> 2012/2/9 Sébastien Brisard <[email protected]>: >> > 2012/2/9 sebb <[email protected]>: >> >> 2012/2/9 Sébastien Brisard <[email protected]>: >> >>> Hi, >> >>> >> >>>> >> >>>> svn:keywords = Id >> >>>> >> >>>> Propchange: >> >>>> commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java >> >>>> ------------------------------------------------------------------------------ >> >>>> svn:keywords = Id >> >>>> >> >>>> Propchange: >> >>>> commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java >> >>>> ------------------------------------------------------------------------------ >> >>>> svn:keywords = Id >> >>>> >> >>>> Propchange: >> >>>> commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java >> >>>> ------------------------------------------------------------------------------ >> >>>> svn:keywords = Id >> >>>> >> >>>> Propchange: >> >>>> commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java >> >>>> ------------------------------------------------------------------------------ >> >>>> svn:keywords = Id >> >>>> >> >>>> >> >>> >> >>> I think the property should read >> >>> Author Date Id Revision >> >> >> >> Please don't use Date - it is locale-dependent and causes SVN tags to >> >> disagree with source archives. >> >> >> >> Also @Author tags are strongly discouraged. >> >> We use changes.xml and contributors in the POM instead. >> >> >> > OK, my mistake. >> > I was conforming with what I saw in existing files. So should the >> > svn:keywords property read "Id", or "Id Revision"? >> >> Both Id and Revision are fine, and can both be useful. >> >> There's no harm in having the keywords set - it's only a problem if >> they are *used*. >> But having them set might encourage their use. > > I think that we decided to stick with $Id$ only since it also contains the > revision number.
It does, but sometimes (often ?) the revision number will be sufficient. What's important is to avoid the properties that cause problems. $Date is bad because it is locale-dependent; $Id offers a way round this. > Regards, > Gilles > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
