On Sun, Dec 11, 2011 at 12:28 PM, Phil Steitz <phil.ste...@gmail.com> wrote:
> On 12/11/11 6:28 AM, Gary Gregory wrote: > > On Sat, Dec 10, 2011 at 9:58 PM, Phil Steitz <phil.ste...@gmail.com> > wrote: > > > >> > >> > >> > >> On Dec 10, 2011, at 6:31 PM, sebb <seb...@gmail.com> wrote: > >> > >>> On 11 December 2011 00:29, Phil Steitz <phil.ste...@gmail.com> wrote: > >>>> This is a patch release, including a couple of bug fixes. > >>>> > >>>> The release artifacts are here: > >>>> http://people.apache.org/~psteitz/pool-1.5.7-rc3/ > >>>> > >>>> Release notes: > >>>> http://people.apache.org/~psteitz/pool-1.5.7-rc3/RELEASE-NOTES.txt > >>>> > >>>> Maven distribution: > >>>> http://people.apache.org/~psteitz/pool-1.5.7-rc3/maven > >>> There's no test jar - I thought we were going to try providing those? > >>> I think that is one of the added features in the CP 22 release profile. > >> This is a patch release identical to 1.5.6 other than the two bug fixes > >> in the release notes. I see no reason to add artifacts. > >> > >>>> Site: > >>>> http://people.apache.org/~psteitz/pool-1.5.7-rc3/docs > >>>> (Links, including an added link to the released API docs, will be > >>>> updated post release) > >>> It would be nice to have a Clirr report for the differences from 1.5.6 > >>> as well as from 1.5. > >>> Dunno if that is possible > >> There were no API changes. > >> > >>>> Tag: > >>>> > http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_5_7_RC3 > >>> Uses old Commons Parent version. > >> That is intentional. Avoids some issues generating artifacts. Again, > >> this is just a patch release on a maintenance branch. No reason to mess > >> with a working build. > >> > > "working", yes on Maven 2, but not on Maven 3: > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-site-plugin:3.0-beta-3:site (default-site) > > on project commons > > to parse configuration of mojo > > org.codehaus.mojo:findbugs-maven-plugin:1.2:findbugs for parameter > > localRepository: Abstract > > .artifact.repository.DefaultArtifactRepository' cannot be instantiated -> > > [Help 1] > > > > Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > > Java version: 1.6.0_29, vendor: Sun Microsystems Inc. > > Java home: C:\Program Files\Java\jdk1.6.0_29\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > C:\temp\commons-pool-1.5.7-src>set java_home=%java_7_home% > > > > It's nice to touch as little as possible in production code for a > > maintenance release, but the build should be OK to move forward IMO. > > Especially when you cannot even build on M3. I also like the consistency > of > > a current releases using the current parent POM. > > No. Maven and maven plugins make incompatible changes regularly. > We can't possibly expect our releases to work with future > incompatible changes in maven or maven plugins. > > I see no reason to reengineer the build between 1.5.6 and 1.5.7 on a > maintenance branch. Is there anything wrong with the release > artifacts or code? > Nope, the production bits are working. I do not look at this as a right or wrong. I just ask myself "Is this the best I can do?" For me, personally, that would be "no". Different strokes for different folks :) Gary > Phil > > > > +0 > > > > Gary > > > > > > > >>> Many source files use $Date:$ SVN markers; these make it awkward to > >>> compare against the SVN tag > >>> > >>>> Votes, please. This vote will close in 72 hours, 14-DEC-01:00 GMT. > >>>> > >>>> [ ] +1 I support this release > >>>> [X] +0 OK, but... > >>>> [ ] -0 Not happy about this because... > >>>> [ ] -1 I oppose this release > >>>> > >>>> Thanks! > >>>> > >>>> Phil > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>>> For additional commands, e-mail: dev-h...@commons.apache.org > >>>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
