On Wed, Oct 26, 2011 at 4:54 AM, Emmanuel Bourg <ebo...@apache.org> wrote:
> +0 > > The test coverage of Pack200CompressorInputStream is a bit low, the read > methods do not seem to be tested. > > Also in the matches() method the constant '4' could be replaced by > CAFE_DOOD.length > > Emmanuel Bourg In the same vein, in trunk now, the following have 0% code coverage according to Cobertura: - Lister - DumpArchiveConstants: How can it have 0% when it is used? Does Cobertura know how to deal with enums? - DumpArchiveException - InvalidFormatException - ShortFileException - UnrecognizedFormatException - UnsupportedCompressionAlgorithmException - TarArchiveSparseEntry - Zip64RequiredException - ZipConstants: Same oddity as above? - ZipFile$BoundedInputStream - CompressorException - Rand The trunk POM uses cobertura-maven-plugin 2.2 (= Cobertura 1.9) and not the latest 2.5.1 (= Cobertura 1.9.4.1). With the latest plugin, the number are a little worse overall and for some classes a little better. The report is more detailed with other classes, with some annon inner classes (...$1) added for example. I've updated the POM in SVN trunk. FYI, reqs are Maven 2.0.8 and Java 5, so we are good. Gary > > > > Le 26/10/2011 06:54, Stefan Bodewig a écrit : > >> Compress 1.3 RC1 is available for review here: >> >> >> http://people.apache.org/~**bodewig/commons-compress/<http://people.apache.org/%7Ebodewig/commons-compress/> >> >> Maven artifacts are here: >> https://repository.apache.org/**content/repositories/** >> orgapachecommons-101/org/**apache/commons/commons-**compress/1.3/<https://repository.apache.org/content/repositories/orgapachecommons-101/org/apache/commons/commons-compress/1.3/> >> >> Details of changes since 1.1 are in the release notes: >> http://people.apache.org/~**bodewig/commons-compress/** >> RELEASE-NOTES.txt<http://people.apache.org/%7Ebodewig/commons-compress/RELEASE-NOTES.txt> >> http://people.apache.org/~**bodewig/commons-compress/site/** >> changes-report.html<http://people.apache.org/%7Ebodewig/commons-compress/site/changes-report.html> >> >> I have tested this with Sun JDK 1.5 and OpenJDK 1.6 using maven2. >> >> The tag is here (revision 1189016): >> http://svn.apache.org/viewvc/**commons/proper/compress/tags/** >> COMPRESS_1.3_RC1/<http://svn.apache.org/viewvc/commons/proper/compress/tags/COMPRESS_1.3_RC1/> >> >> Site: >> >> http://people.apache.org/~**bodewig/commons-compress/site/<http://people.apache.org/%7Ebodewig/commons-compress/site/> >> >> Clirr Report (compared to 1.2): >> http://people.apache.org/~**bodewig/commons-compress/site/** >> clirr-report.html<http://people.apache.org/%7Ebodewig/commons-compress/site/clirr-report.html> >> >> RAT Report: >> http://people.apache.org/~**bodewig/commons-compress/site/** >> rat-report.html<http://people.apache.org/%7Ebodewig/commons-compress/site/rat-report.html> >> >> Votes, please. This vote will close in 72 hours, 0500 GMT 29-October >> 2011 >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> >> ------------------------------**------------------------------**--------- >> To unsubscribe, e-mail: >> dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org> >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org> > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
