On Wed, Oct 26, 2011 at 7:02 AM, Stefan Bodewig <bode...@apache.org> wrote:
> On 2011-10-26, Stefan Bodewig wrote: > > > On 2011-10-26, Emmanuel Bourg wrote: > > >> The test coverage of Pack200CompressorInputStream is a bit low, the > >> read methods do not seem to be tested. > > > Only the three-arg version is used, this is true. > > > I'll look into getting more coverage in trunk so it will improve with > > the next release (or the next RC if this vote fails). > > 82% line coverage and 100% branch coverage in trunk. No code changes in > main, no test failures. > > While I was at it I added test for CountingInputStream to make the > statistics look nicer. > Also should be fixed but not show stoppers: Description Resource Path Location Type The value of the field ArArchiveOutputStream.archiveOffset is not used ArArchiveOutputStream.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/ar line 42 Java Problem Unnecessary cast from byte to int DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 111 Java Problem Unnecessary cast from byte to int DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 112 Java Problem Unnecessary cast from byte to int DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 113 Java Problem Unnecessary cast from byte to int DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 114 Java Problem Unnecessary cast from byte to int DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 128 Java Problem Unnecessary cast from byte to int DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 129 Java Problem Unnecessary cast from byte to long DumpArchiveUtil.java /commons-compress/src/main/java/org/apache/commons/compress/archivers/dump line 97 Java Problem Gary > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
