I've made some minor adjustments, and uploaded the snapshot. Seems to work fine for me. Tested in NET; also works for the extra jars created by Ant so long as the manifest is updated accordingly.
On 9 September 2011 15:02, Simone Tripodi <simonetrip...@apache.org> wrote: > hi all guys, > I just committed the r1167170 of the parent pom, please review. > Any suggestion/improvement is welcome, feel free to work on it! :) > Since Olivier is also the buildnumber plugin maintainer can more than useful! > Have a nice day, all the best! > Simo > > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > > > > On Fri, Sep 9, 2011 at 3:53 PM, Olivier Lamy <ol...@apache.org> wrote: >> Maybe possible to add something for folks using git svn. >> >> An other profile activated if .git is present and change the scm >> provider used for buildnumber (see [1] ) : >> providerImplementations : <svn>git</svn> (hackhish maybe and not tested :-) >> ). >> >> The git scm provider use : git rev-parse --verify HEAD . >> Which produce a result even with git svn. >> >> -- >> Olivier >> >> [1] http://mojo.codehaus.org/buildnumber-maven-plugin/using-svnjava.html >> >> 2011/9/9 Simone Tripodi <simonetrip...@apache.org>: >>> OK, >>> I also did a little experiment following Olivier's suggestions and it >>> worked. >>> Just the time to revert to the initial form so I can commit and you >>> all can see how it works and play with it. >>> TIA! >>> Simo >>> >>> http://people.apache.org/~simonetripodi/ >>> http://www.99soft.org/ >>> >>> >>> >>> On Fri, Sep 9, 2011 at 3:41 PM, sebb <seb...@gmail.com> wrote: >>>> On 9 September 2011 14:28, Simone Tripodi <simonetrip...@apache.org> wrote: >>>>> @Seb: revision-unknown sounds better indeed >>>>> >>>>> @Olivier: you are always super :) going to move the stuff to the profile >>>> >>>> Not sure I agree that the profile is a good idea; it only works for >>>> Subversion (the plugin supports other CMS) and the test relies on an >>>> implementation detail of SVN. >>>> >>>> Unless the plugin causes issues for non-workspace builds, I think it's >>>> better if it is always active. >>>> Alternatively, it could be in a profile that is active by default; the >>>> profile could then be disabled if it turns out later that there are >>>> edge cases that fail. >>>> >>>>> WDYT if I commit that stuff and reverting if starts creating issues? >>>>> we have Olivier in any way ;) >>>> >>>> +1, we need to be able to try it easily. >>>> >>>>> Simo >>>>> >>>>> >>>>> http://people.apache.org/~simonetripodi/ >>>>> http://www.99soft.org/ >>>>> >>>>> >>>>> >>>>> On Fri, Sep 9, 2011 at 3:10 PM, Olivier Lamy <ol...@apache.org> wrote: >>>>>> why not having a profile for that ? (folks using git svn or building >>>>>> from the src distrib). >>>>>> >>>>>> <profile> >>>>>> <id>buildnumber</id> >>>>>> <activation> >>>>>> <file> >>>>>> <exists>.svn</exists> >>>>>> </file> >>>>>> </activation> >>>>>> <build> >>>>>> <plugins> >>>>>> <plugin> >>>>>> <groupId>org.codehaus.mojo</groupId> >>>>>> <artifactId>buildnumber-maven-plugin</artifactId> >>>>>> blabla setup of the plugin >>>>>> </plugin> >>>>>> </plugins> >>>>>> </build> >>>>>> </profile> >>>>>> >>>>>> 2011/9/9 Simone Tripodi <simonetrip...@apache.org>: >>>>>>> The plugin supports the offline mode, I configured it to add >>>>>>> >>>>>>> Implementation-Build: local-dev; 2011-09-09 09:17:22+0200 >>>>>>> >>>>>>> instead of >>>>>>> >>>>>>> Implementation-Build: r1166864; 2011-09-09 09:17:22+0200 >>>>>>> >>>>>>> WDYT? >>>>>>> Simo >>>>>>> >>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>> http://www.99soft.org/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Sep 9, 2011 at 2:59 PM, sebb <seb...@gmail.com> wrote: >>>>>>>> On 9 September 2011 08:35, Simone Tripodi <simonetrip...@apache.org> >>>>>>>> wrote: >>>>>>>>> Good morning guys, >>>>>>>>> I just did an experiment on my local checkout of the parent pom, >>>>>>>>> adding the buildnumber plugin, in order to have a new >>>>>>>>> `Implementation-Build` manifest entry in the jars, where reported the >>>>>>>>> revision number and the timestamp. >>>>>>>>> I applied locally on [chain] and got: >>>>>>>>> >>>>>>>>> Implementation-Build: r1166864; 2011-09-09 09:17:22+0200 >>>>>>>>> >>>>>>>>> I'd like to commit it if no one has objections, if needed I can fill >>>>>>>>> an Issue and attach the patch. >>>>>>>>> Please let me know, thanks in advance! >>>>>>>> >>>>>>>> What happens if you try running a build outside the SVN workspace? >>>>>>>> >>>>>>>> e.g. a user may just download a source archive, and try building from >>>>>>>> that. >>>>>>>> >>>>>>>>> Have a nice day, >>>>>>>>> Simo >>>>>>>>> >>>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>>> http://www.99soft.org/ >>>>>>>>> >>>>>>>>> --------------------------------------------------------------------- >>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Olivier Lamy >>>>>> Talend : http://talend.com >>>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> >> >> >> -- >> Olivier Lamy >> Talend : http://talend.com >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
