On Sat, Jul 30, 2011 at 2:27 AM, Henri Yandell <flame...@gmail.com> wrote: > On Fri, Jul 29, 2011 at 8:27 AM, Gary Gregory <garydgreg...@gmail.com> wrote: >> Hi Hen, >> >> I am not really comfortable knowing that a SOE can be a "normal" code >> path. It would have to be Javadoc'd to boot. >> >> I can see catching IllegalStateException and IllegalArgumentException >> in client code, especially in a server or a processor of some kind, >> but to do that for SOE feels wrong. An SOE would crash a server based >> a client request for example. > > Any thoughts on how to define an arbitrary number of loops to allow? > Throwing an ISE (or IAE) to protect against SOE when it's a loop of 2 > is a bit aggressive :) > >> I think I'd rather keep the exception. Also I think it should be an >> IAE instead of an ISE because the problem is that the arguments are >> bad and the SU class does have state. > > I think it used to be an IAE. The javadoc definitely was. > > Easy to change back.
Looking at the history of the code, I think it's always been an ISE with an IAE listed in the javadoc. Additionally array lengths have thrown an IAE and declared a IndexOutOfBoundsException. Lovely :) For now my intention is to fix the javadoc and improve the exception method and discuss other changes later. Hen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
